io: Correct handling of byte count pos in TBufferFile::ReadObjectAny #21192
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note that 588b29e was also not reviewed. |
Test Results 22 files + 1 22 suites +1 3d 9h 24m 26s ⏱️ - 2h 59m 12s For more details on these failures, see this check. Results for commit c103e87. ± Comparison against base commit 588b29e. |
Collaborator
|
Closing #20498 since it seems this is an alternative / better approach |
jblomer
approved these changes
Feb 9, 2026
Comment on lines
+2596
to
+2597
| ULong64_t startpos = static_cast<ULong64_t>(fBufCur-fBuffer); | ||
| ULong64_t cntpos = startpos <= kMaxCountPosition ? startpos : kOverflowPosition; |
Contributor
There was a problem hiding this comment.
Don't we need to push the startpos on the stack if it's large?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a missing commit for #21183 which was merge a bit too soon.