Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove visibility macros (backport #539) #544

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jul 26, 2024

As a consequence of ros-controls/ros2_control#1627 there is an include for HARWARE_INTERFACE_PUBLIC missing, causing the build of example_7 to fail.

As we've discussed and decided in ros-controls/ros2_controllers#1053, we wanted to remove all the visibility macros and use set(CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS ON) instead. I took the chance to do so here.

Fixes #538 and also resolves #73

* Remove visibility macros

* Remove dead target_compile_definitions

(cherry picked from commit f92cc21)
@christophfroehlich christophfroehlich merged commit 7dda234 into humble Jul 26, 2024
8 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-539 branch July 26, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant