- 
                Notifications
    You must be signed in to change notification settings 
- Fork 409
Add motion_primitives_from_trajectory_controller with trajectory approximation using PTP/LIN primitives #1858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
        
      
            mathias31415
  wants to merge
  131
  commits into
  ros-controls:master
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
b-robotized-forks:moprim_from_traj_controller_with_base_controller
  
      
      
   
  
    
  
  
  
 
  
      
    base: master
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
                
     Open
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    …time --> added gitignore, to not push it to github --> remove it after everything is done
… the hardware interface can receive a new motion primitive — replaces the previous, more complex handling via execution_status
…ls according to other controllers in the repo
… rtw template to fit the controller implementation
…tation from rtw template to fit the controller implementation
…ontroller namespace
…o_moprim_base_controller
…_traj_controller_with_base_controller
…_traj_controller_with_base_controller
… and blend_radius_upper_limit
…o_moprim_base_controller
…_traj_controller_with_base_controller
| This pull request is in conflict. Could you fix it @mathias31415? | 
| Codecov Report❌ Patch coverage is  Additional details and impacted files@@            Coverage Diff             @@
##           master    #1858      +/-   ##
==========================================
- Coverage   85.25%   81.73%   -3.52%     
==========================================
  Files         143      148       +5     
  Lines       13794    14388     +594     
  Branches     1194     1279      +85     
==========================================
  Hits        11760    11760              
- Misses       1636     2230     +594     
  Partials      398      398              
 Flags with carried forward coverage won't be shown. Click here to find out more. 
 🚀 New features to boost your workflow:
 | 
…controller_with_base_controller
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR adds the motion_primitives_from_trajectory_controller. To make reviewing easier, another PR #1857 was created first to move shared functionality into a base controller.
This PR replaces PR #1837.
This PR is marked as a draft because PR #1636 and PR #1857 must be merged first.
This PR complements motion_primitives_forward_controller PR #1636 .
Instead of sending hardcoded motion primitives to the
motion_primitives_forward_controller, this controller (motion_primitives_from_trajectory_controller) approximates aJointTrajectoryusing eitherPTPorLINmotion primitives.This allows, for example, collision-free paths planned with MoveIt to be executed as motion primitives. The approximation is performed using the Ramer-Douglas-Peucker (RDP) algorithm:
PTPprimitives in joint spaceLINprimitives in Cartesian space