Skip to content

Added linux pc setup script #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 1, 2023

Conversation

hilary-luo
Copy link
Contributor

This script is intended to automate the remaining manual setup steps for most linux pcs (creating and populating the user group and increasing the usbfs memory limits as per https://github.com/ros-drivers/flir_camera_driver/blob/humble-devel/spinnaker_camera_driver/docs/linux_setup_flir.md).

Copy link
Member

@tonybaltovski tonybaltovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could a note be added to the README explain how to use this?

sudo addgroup flirimaging
sudo usermod -a -G flirimaging ${USER}

val=$(< /sys/module/usbcore/parameters/usbfs_memory_mb)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a prompt to ask if they would like do this as well.

Copy link
Collaborator

@berndpfrommer berndpfrommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Once you have merged it I will update the README to suggest running the script for setup first.

@hilary-luo
Copy link
Contributor Author

All recommendations have been implemented including modifying of the Readme, please let me know if either of you have any additional feedback.

@berndpfrommer
Copy link
Collaborator

looks good to me, @tonybaltovski please rebase and merge once you are happy with the changes

@tonybaltovski tonybaltovski merged commit dbb5f16 into ros-drivers:humble-devel Nov 1, 2023
@hilary-luo hilary-luo deleted the setup-script branch November 1, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants