Load Plugins W/ Params #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AustinDeric or @woodaaron please review. |
woodaaron
reviewed
Feb 22, 2017
|
@woodaaron Per your requests, I have changed the plugin names to be loaded dynamically at each call. Currently this means through the ROS server. If we're going to be changing the plugin, I think adding GUI fields is probably the "right" way but this will do for the moment. That's low priority in my book. |
added 2 commits
February 22, 2017 21:51
…, and scan tool pluins from ROS params.
Jmeyer1292
force-pushed
the
feature/plugins_through_params
branch
from
fbcbd64
to
7716243
Compare
|
I made an Issue #164 to dynamically select plugins using the GUI. Everything else looks good on this. |
AustinDeric
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title mentions, this just changes the plugins being loaded from hard-coded names to something that we can set through a YAML file at run time.