-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce boost dependency scope #118
Conversation
debian buster build has a failing unit test:
|
Trying another build... |
... and the next build went through. |
@mjcarroll I'd appreciate your review/merge. Thanks! |
Compiles here and LGTM; merging! |
@mjcarroll @gbiggs is it possible to release a new version with this change in ROS Noetic ? This package is the last of the
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: https://discourse.ros.org/t/package-separation-for-building-and-running-ros-applications/35527/3 |
Great thanks! |
<depend>boost</depend>
resolves tolibboost-all-dev
on Ubuntu which is far too much for what is really needed. The-dev
packages should never be needed at runtime. Instead, the corresponding libboost* (without -dev) libraries should be used as run_depend/exec_depend. Many boost libraries are also header only and don't need a runtime dependency either.This PR should reduce the scope of boost dependencies quite a bit.