Open
Conversation
087e9fe to
04d7f5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three new capabilities to the parameter API:
ParameterBuilder::validate()to register a callback that can reject parameter changes. Called during declaration (for the initial value) and on every subsequent set, both programmatic and via service calls. Runs after range checks, before the value is written.MandatoryParameter::on_change()/OptionalParameter::on_change()to register a callback invoked after a parameter value is successfully changed. Intended for side effects (reconfiguring algorithms, logging, etc.). Callbacks are invoked outside the parameter map lock to avoid deadlocks.MandatoryParameter::subscribe()/OptionalParameter::subscribe()that return aParameterSubscriptionfor async notification of changes viatokio::sync::watch. Supportschanged(),get(), andwait_for(predicate). The naming might be slightly confusing with subscribers already being a foundational ROS 2 concept, let me know if there are better naming ideas.Also adds
ValidationFailedandInitialValueRejectederror variants toParameterValueErrorandDeclarationErrorrespectively.Examples can be found here: https://github.com/azerupi/ros2_rust_examples/tree/parameter_callback_v2
Disclaimer AI was used to help write this PR