-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update comment #757
Merged
clalancette
merged 3 commits into
ros2:rolling
from
iuhilnehc-ynos:topic-update-comment
Jul 19, 2023
Merged
update comment #757
clalancette
merged 3 commits into
ros2:rolling
from
iuhilnehc-ynos:topic-update-comment
Jul 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen Lihui <lihui.chen@sony.com>
iuhilnehc-ynos
requested review from
adityapande-1995,
methylDragon,
quarkytale and
sloretz
as code owners
July 17, 2023 01:44
iuhilnehc-ynos
commented
Jul 17, 2023
rosidl_typesupport_introspection_c/resource/srv__type_support.c.em
Outdated
Show resolved
Hide resolved
clalancette
requested changes
Jul 17, 2023
rosidl_typesupport_introspection_c/resource/srv__type_support.c.em
Outdated
Show resolved
Hide resolved
Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com>
emersonknapp
approved these changes
Jul 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change - any number written in a comment inevitably becomes incorrect
clalancette
requested changes
Jul 18, 2023
Co-authored-by: Chris Lalancette <clalancette@gmail.com> Signed-off-by: Chen Lihui <lihui.chen@sony.com>
clalancette
approved these changes
Jul 19, 2023
Going ahead and merging this one (the timers_manager test failure is a known Windows flake). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.