Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update comment #757

Merged
merged 3 commits into from
Jul 19, 2023
Merged

update comment #757

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4df1722
update comment
Jul 17, 2023
1dd1d2c
use a generic meaning to avoid updating in the future
Jul 17, 2023
456d5e0
Update other comments that do not mention the event
Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rosidl_typesupport_introspection_c/resource/srv__type_support.c.em
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ function_prefix = '__'.join(include_parts) + '__rosidl_typesupport_introspection
static rosidl_typesupport_introspection_c__ServiceMembers @(function_prefix)__@(service.namespaced_type.name)_service_members = {
"@('__'.join([package_name] + list(interface_path.parents[0].parts)))", // service namespace
"@(service.namespaced_type.name)", // service name
// these two fields are initialized below on the first access
// the following fields are initialized below on first access
NULL, // request message
// @(function_prefix)__@(service.request_message.structure.namespaced_type.name)_message_type_support_handle,
NULL, // response message
Expand Down
3 changes: 1 addition & 2 deletions rosidl_typesupport_introspection_cpp/resource/srv__type_support.cpp.em
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ namespace rosidl_typesupport_introspection_cpp
static ::rosidl_typesupport_introspection_cpp::ServiceMembers @(service.namespaced_type.name)_service_members = {
"@('::'.join([package_name] + list(interface_path.parents[0].parts)))", // service namespace
"@(service.namespaced_type.name)", // service name
// these two fields are initialized below on the first access
// the following fields are initialized below on first access
// see get_service_type_support_handle<@('::'.join([package_name] + list(interface_path.parents[0].parts) + [service.namespaced_type.name]))>()
nullptr, // request message
nullptr, // response message
Expand Down Expand Up @@ -134,7 +134,6 @@ get_service_type_support_handle<@('::'.join([package_name] + list(interface_path
::@('::'.join([package_name] + list(interface_path.parents[0].parts)))::@(service.response_message.structure.namespaced_type.name)
clalancette marked this conversation as resolved.
Show resolved Hide resolved
>()->data
);

// initialize the event_members_ with the static function from the external library
service_members->event_members_ = static_cast<
const ::rosidl_typesupport_introspection_cpp::MessageMembers *
Expand Down