Use longer identifier for DatabaseLimits when using Oracle 12.2 or higher
#2128
Conversation
koic
force-pushed
the
use_longer_identifier_for_oracle_12c
branch
2 times, most recently
from
498c5d9
to
ce00caa
Compare
…higher Follow rsim#1703. Oracle enhanced adapter supports longer identifier by rsim#1703. I encountered the following error when using `rename_table` in Oracle 12c. ```console New table name 'identifier_of_thirty_bytes_or_more' is too long; the limit is 30 characters ``` Because `IDENTIFIER_MAX_LENGTH` constant was fixed to 30 bytes. This PR will use `max_identifier_length` method instead of the constant and accept longer identifier (max 128 bytes) when using Oracle 12.2 or higher. I encountered the error in Rails 6.0. So I'd like to backport to 6.1 and 6.0 stable branches.
koic
force-pushed
the
use_longer_identifier_for_oracle_12c
branch
from
ce00caa
to
e605c2a
Compare
| @@ -457,7 +457,7 @@ def write_lob(lob, value, is_binary = false) | |||
| end | |||
|
|
|||
| # To allow private method called from `JDBCConnection` | |||
| def describe(name) | |||
| def describe(name, supports_longer_identifier) | |||
There was a problem hiding this comment.
Do you mean supports_longer_identifier?
There was a problem hiding this comment.
Yes. It takes the result of ActiveRecord::ConnectionAdapters::OracleEnhancedAdapter#supports_longer_identifier? as argument. Unfortunately no better name has come up yet.
|
I found that there will probably be breaking change in this PR. Please wait for a while due to I will investigate it. |
|
Sure. Although I have not checked this pull request in detail yet, In general, I prefer not to change method signature/arity for this requirement. Because the Oracle database version never changes per database connection. Also, I especially prefer not to change the method signature if it requires to backport to the older versions of Oracle enhanced adapter. Let's have some discussion if you have questions. Thank you. |
|
Any updates on this? |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Is there any work that needs to be completed on this? If so, I'd be happy to help. I am eager to see this in a release! |
|
@mattalat, the biggest complaint I see is changing of the method signatures. Since identifiers are same for the whole connection, I think that probably detecting their length within the connection and then accessing that value wherever needed would resolve that. Also my suggestion would be to have a method that returns length of identifiers instead of |
Follow #1703.
Oracle enhanced adapter supports longer identifier by #1703.
I encountered the following error when using
rename_tablein Oracle 12c.New table name 'identifier_of_thirty_bytes_or_more' is too long; the limit is 30 charactersBecause
IDENTIFIER_MAX_LENGTHconstant was fixed to 30 bytes.This PR will use
max_identifier_lengthmethod instead of the constant and accept longer identifier (max 128 bytes) when using Oracle 12.2 or higher.I encountered the error in Rails 6.0. So I'd like to backport to 6.1 and 6.0 stable branches.