Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use longer identifier for DatabaseLimits when using Oracle 12.2 or higher #2128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jan 19, 2021

  1. Use longer identifier for DatabaseLimits when using Oracle 12.2 or …

    …higher
    
    Follow rsim#1703.
    
    Oracle enhanced adapter supports longer identifier by rsim#1703.
    I encountered the following error when using `rename_table` in Oracle 12c.
    
    ```console
    New table name 'identifier_of_thirty_bytes_or_more' is too long; the limit is 30 characters
    ```
    
    Because `IDENTIFIER_MAX_LENGTH` constant was fixed to 30 bytes.
    
    This PR will use `max_identifier_length` method instead of the constant and
    accept longer identifier (max 128 bytes) when using Oracle 12.2 or higher.
    
    I encountered the error in Rails 6.0. So I'd like to backport to 6.1 and 6.0 stable branches.
    koic committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    e605c2a View commit details
    Browse the repository at this point in the history