Remove warnings #809
Open
Remove warnings #809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswgnu
requested changes
Nov 7, 2025
| (format "*eww-%s*" (url-host (url-generic-parse-url | ||
| (eww--dwim-expand-url url))))))) | ||
| (eww-mode) | ||
| (defvar url-allow-non-local-files) ; Defined from Emacs 29. |
Owner
There was a problem hiding this comment.
Fix the Changelog comment that references a different variable name.
Collaborator
Author
There was a problem hiding this comment.
Good catch. It is unclear. The reference is to the function where the defvar is placed. But the text does not mention which variable is defvar'ed. I tried to resolve it by adding the name of the variable while keeping the reference to the function. WDYT, OK?
matsl
force-pushed
the
silence_a_few_minor_warnings
branch
from
989bd03 to
2fd052e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Silence two byte compilation warnings.
Why
Byte compile should be as clean as possible.