Skip to content

Remove warnings #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 9, 2025
Merged

Remove warnings #809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02473f6
Remove warnings
matsl Nov 7, 2025
2fd052e
Mention defvar'ed variable name in ChangeLog
matsl Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions ChangeLog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
2025-11-07 Mats Lidell <matsl@gnu.org>

* hsys-www.el (eww--dwim-expand-url): Declare function to silence warning.
(www-eww-browse-url): Defvar url-allow-non-local-files to silence
warning in Emacs 28 where it is not defined. Introduced with Emacs 29.

2025-11-06 Mats Lidell <matsl@gnu.org>

* test/hywiki-tests.el (hywiki-tests--hywiki-face-regions): Helper for
Expand Down
5 changes: 4 additions & 1 deletion hsys-www.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
;; Author: Bob Weiner
;;
;; Orig-Date: 7-Apr-94 at 17:17:39 by Bob Weiner
;; Last-Mod: 5-Oct-25 at 13:51:02 by Bob Weiner
;; Last-Mod: 7-Nov-25 at 19:23:34 by Mats Lidell
;;
;; SPDX-License-Identifier: GPL-3.0-or-later
;;
Expand Down Expand Up @@ -43,6 +43,8 @@

(defvar hpath:display-where-alist) ; "hpath.el"

(declare-function eww--dwim-expand-url "eww" (url))

(declare-function hpath:remote-available-p "hpath")
(declare-function hpath:remote-p "hpath")
(declare-function hpath:remote-at-p "hpath")
Expand Down Expand Up @@ -226,6 +228,7 @@ instead of `browse-url-new-window-flag'."
(format "*eww-%s*" (url-host (url-generic-parse-url
(eww--dwim-expand-url url)))))))
(eww-mode)
(defvar url-allow-non-local-files) ; Defined from Emacs 29.
Copy link
Owner

@rswgnu rswgnu Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the Changelog comment that references a different variable name.

Copy link
Collaborator Author

@matsl matsl Nov 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. It is unclear. The reference is to the function where the defvar is placed. But the text does not mention which variable is defvar'ed. I tried to resolve it by adding the name of the variable while keeping the reference to the function. WDYT, OK?

(let ((url-allow-non-local-files t))
(eww url)))

Expand Down