Make rendering test faster using updated yamatanooroti #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YO4
reviewed
Sep 13, 2024
| @@ -1902,13 +1902,14 @@ def test_stop_continue | |||
| rubyfile.close | |||
| start_terminal(40, 50, ['bash']) | |||
| write "ruby -I#{@pwd}/lib -rreline #{rubyfile.path}\n" | |||
| assert_screen(/^>/) | |||
| write "abc\ndef\nhi" | |||
| pid = pidfile.tap(&:rewind).read.to_i | |||
| Process.kill(:STOP, pid) unless pid.zero? | |||
| write "fg\n" | |||
There was a problem hiding this comment.
It seems to wait to ruby waking up after fg.
How about assert_screen(/fg\n.*>/m)
There was a problem hiding this comment.
Looks great, thanks! added
tompng
force-pushed
the
new_yamatanooroti
branch
from
6e7198b
to
24e9d40
Compare
tompng
force-pushed
the
new_yamatanooroti
branch
from
24e9d40
to
b14e280
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes test_rendering faster. Yamatanooroti's wait time is reduced from 0.1 sec to 0.01 sec
rake test_yamatanooroti(vterm-yamatanooroti ubuntu-latest head) 209 seconds → 57 seconds