Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Reline crash with invalid encoding history #751

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fix Reline crash with invalid encoding history #751

merged 1 commit into from
Oct 1, 2024

Conversation

tompng
Copy link
Member

@tompng tompng commented Sep 24, 2024

Fixes #615 and ruby/irb#86

Points:

  • Reline::LineEditor only supports utf8 convertible valid byte sequences.
  • Not all characters are convertible to utf8.
  • Some sjis to utf8 conversion are not reversible.

@tompng tompng mentioned this pull request Sep 24, 2024
Merged
ima1zumi
ima1zumi reviewed Sep 30, 2024
View reviewed changes
lib/reline/unicode.rb
Comment on lines +62 to +70
converted.gsub(/\X/) do |c|
c.encode(Encoding::UTF_8)
c
rescue Encoding::UndefinedConversionError
'?'
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment?

ima1zumi
ima1zumi approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@ima1zumi ima1zumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ima1zumi ima1zumi merged commit e9d4b37 into ruby:master Oct 1, 2024
40 checks passed
matzbot pushed a commit to ruby/ruby that referenced this pull request Oct 1, 2024
@tompng @matzbot
[ruby/reline] Fix Reline crash with invalid encoding history
e320da6 
(ruby/reline#751)

ruby/reline@e9d4b37e34
@tompng tompng deleted the history_encoding_safe branch October 1, 2024 17:02
@tompng tompng mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ima1zumi ima1zumi ima1zumi approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reline crash when loading Illegal string encoded differently from the current terminal
2 participants
@tompng @ima1zumi