Restore install as default command
#9125
Closed
+25
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: ruby#9124 This behavior is a deeply entrenched convention and changing it will annoy lots of developers with unclear gains.
byroot
force-pushed
the
default-cli-install
branch
from
5232065 to
9833263
Compare
Contributor
|
We can probably just revert my commit and set the default to |
Member
|
Altanative is #9126 |
eregon
approved these changes
Nov 27, 2025
byroot
force-pushed
the
default-cli-install
branch
from
b8cf5f8 to
b3994cb
Compare
As mentioned in ruby#9124, the intent for changing the default command was to be more welcoming. I think we can acheive that by attempting to install, but to print that same help message if there is no Gemfile. That should address both concerns.
byroot
force-pushed
the
default-cli-install
branch
from
b3994cb to
d1634c7
Compare
byroot
commented
Nov 28, 2025
| def find_command_possibilities(meth) | ||
| len = meth.to_s.length | ||
| possibilities = all_commands.merge(map).keys.select { |n| meth == n[0, len] }.sort | ||
| possibilities = all_commands.reject { |_k, c| c.hidden? }.merge(map).keys.select { |n| meth == n[0, len] }.sort |
Member
Author
There was a problem hiding this comment.
I had to add code to filter out hidden commands otherwise install_or_cli_help would show up in suggestons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #9124
This behavior is a deeply entrenched convention and changing it will annoy lots of developers with unclear gains.