Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for File.realpath for going one level up from a filename to get a directory #1060

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Add test for File.realpath for going one level up from a filename to get a directory #1060

merged 2 commits into from
Aug 28, 2023

Conversation

herwinw
Copy link
Member

@herwinw herwinw commented Aug 27, 2023

And clean up the checks for source locations to use __dir__ instead of __FILE__, since it's the directory we're looking for.

@eregon eregon merged commit bb5300b into ruby:master Aug 28, 2023
10 checks passed
@herwinw herwinw deleted the file_realpath_file_to_dir branch August 28, 2023 10:50
@herwinw herwinw mentioned this pull request Aug 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herwinw @eregon