Addiing gh action for spelling errors #1174

CBID2 · 2023-06-27T03:48:43Z

Fixes Issue

Closes #1080

Changes proposed

I added a GitHub Action that encourages contributors to revise spelling errors in their PRs.

Screenshots

Note to reviewers

@saikiranreddy201, I'm open to your suggestions on how to improve this. For context, check out the GH Actions link here

vercel · 2023-06-27T03:48:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
linkshub	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 2, 2023 6:17am

github-actions

Thank you, CBID2, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

saikiranreddy201 · 2023-06-27T04:20:01Z

Hey @CBID2, Since the "pull_request_target" event already covers "opened," "reopened," and "synchronize" types, there is no need to specify them individually.

You can achieve this by changing the follow code snippet

pull_request_target:
    branches:
    - "**"
    tags-ignore:
    - "**"
    types:
    - 'opened'
    - 'reopened'
    - 'synchronize'

to this

pull_request_target:
branches:
 - "**"
tags-ignore:
 - "**"

CBID2 · 2023-06-27T04:20:57Z

pull_request_target:
branches:

"**"
tags-ignore:

"**"

Where should I put it @saikiranreddy201?

.github/workflows/spelling.yml

saikiranreddy201 · 2023-06-27T04:22:56Z

@CBID2, I have added a comment in the review section, please do checkout!

…or-spelling-errors' into addiing-gh-action-for-spelling-errors

CBID2 · 2023-06-27T04:25:46Z

Hey @CBID2, Since the "pull_request_target" event already covers "opened," "reopened," and "synchronize" types, there is no need to specify them individually.

You can achieve this by changing the follow code snippet
pull_request_target:
    branches:
    - "**"
    tags-ignore:
    - "**"
    types:
    - 'opened'
    - 'reopened'
    - 'synchronize'
to this
pull_request_target:
branches:
 - "**"
tags-ignore:
 - "**"

Thanks

ujjawaltyagii · 2023-06-29T04:49:14Z

@CBID2 The deployment shouldn't have caused error then why deployment is getting failed 0_0

CBID2 · 2023-06-29T04:51:50Z

@CBID2 The deployment shouldn't have caused error then why deployment is getting failed 0_0

I don't know @ujjawaltyagii. Unfortunately, only @rupali-codes has access to Vercel.

rupali-codes · 2023-06-29T12:21:13Z

@CBID2 your vercel deployment is getting failed because of the following issues

CBID2 · 2023-06-29T13:03:06Z

@CBID2 your vercel deployment is getting failed because of the following issues

Ahh I see @rupali-code. Where should I put the file then?

CBID2 · 2023-06-30T12:47:21Z

@k-deepak04, I could use help with this

k-deepak04 · 2023-06-30T12:50:09Z

@k-deepak04, I could use help with this

Didn't get what you have written
Do you want my help in this?

CBID2 · 2023-07-01T06:09:25Z

@CBID2 don't know why the return does not have any code in preview , while writing that i was able to see the code.

please let me know how i can share the code.....with you

My preference is Feedback Technique # 5

k-deepak04 · 2023-07-01T06:18:48Z

@CBID2 tried but the deployement is still failing

@rupali-codes please give me the response ss why it's failing

rupali-codes · 2023-07-01T14:53:47Z

@k-deepak04 & @CBID2 its failing because of this

CBID2 · 2023-07-01T14:55:18Z

@k-deepak04 & @CBID2 its failing because of this

So what should I do @rupali-codes? I'm not familiar with Typescript

k-deepak04 · 2023-07-02T05:40:05Z

@k-deepak04 & @CBID2 its failing because of this

So what should I do @rupali-codes? I'm not familiar with Typescript

same have experience in nextjs,reactjs not this.

rupali-codes · 2023-07-02T06:18:30Z

@CBID2 & @k-deepak04 there you go!

CBID2

Done

CBID2 · 2023-07-02T06:20:32Z

@CBID2 & @k-deepak04 there you go!

Thank you @rupali-codes! Now I just need an approved review

rupali-codes

@CBID2 you have tested this right?

CBID2 · 2023-07-03T17:39:57Z

@CBID2 you have tested this right?

No @rupali-codes. How can I go about doing so?

rupali-codes · 2023-07-04T15:18:20Z

@CBID2 you have tested this right?

No @rupali-codes. How can I go about doing so?

I guess we should merge and lets see :)

CBID2 · 2023-07-04T15:19:17Z

@CBID2 you have tested this right?

No @rupali-codes. How can I go about doing so?

I guess we should merge and lets see :)

Ok, approve my PR

This reverts commit bb7aa7b.

k-deepak04 · 2023-08-04T16:45:40Z

i have tested one spell checker

k-deepak04 · 2023-08-04T17:01:43Z

i have tested one spell checker

@CBID2 check this, it detects requres spelling and other ones

CBID2 · 2023-08-04T17:03:02Z

i have tested one spell checker

@CBID2 check this, it detects requres spelling and other ones

Ok

CBID2 and others added 5 commits May 31, 2023 20:59

Update CODEOWNERS

ec2193a

Merge branch 'rupali-codes:main' into main

167dc02

Update Header.tsx

fa38bbf

[fix] add import

9471102

feat: add GitHub Action for spelling errors

88c2f5c

CBID2 requested review from rupali-codes and ujjawaltyagii as code owners June 27, 2023 03:48

CBID2 self-assigned this Jun 27, 2023

github-actions bot reviewed Jun 27, 2023

View reviewed changes

vercel bot deployed to Preview June 27, 2023 03:49 View deployment

CBID2 added goal: new-feature New feature or request collab Open to collaborate with another contributor and/or maintainer labels Jun 27, 2023

Merge branch 'main' into addiing-gh-action-for-spelling-errors

ff0cced

vercel bot had a problem deploying to Preview June 27, 2023 04:03 Failure

saikiranreddy201 reviewed Jun 27, 2023

View reviewed changes

.github/workflows/spelling.yml Outdated Show resolved Hide resolved

CBID2 added 2 commits June 27, 2023 04:24

fix: removed types

23ca08e

Merge remote-tracking branch 'refs/remotes/origin/addiing-gh-action-f…

b040544

…or-spelling-errors' into addiing-gh-action-for-spelling-errors

vercel bot had a problem deploying to Preview June 27, 2023 04:25 Failure

CBID2 mentioned this pull request Jun 29, 2023

[Feature] Search enhancement #1144

Merged

Update Header.tsx

69608b2

vercel bot had a problem deploying to Preview July 1, 2023 06:14 Failure

Merge branch 'main' into addiing-gh-action-for-spelling-errors

ab64f27

vercel bot had a problem deploying to Preview July 1, 2023 06:17 Failure

chore: fix vercel deployment

6a1f210

vercel bot had a problem deploying to Preview July 2, 2023 06:13 Failure

chore: fix errors

67e301d

vercel bot deployed to Preview July 2, 2023 06:17 View deployment

CBID2 commented Jul 2, 2023

View reviewed changes

k-deepak04 approved these changes Jul 2, 2023

View reviewed changes

CBID2 added the status: ready-to-merge Approved & its ready-to-merge label Jul 3, 2023

rupali-codes reviewed Jul 3, 2023

View reviewed changes

rupali-codes approved these changes Jul 4, 2023

View reviewed changes

rupali-codes merged commit bb7aa7b into rupali-codes:main Jul 4, 2023
4 checks passed

rupali-codes added a commit that referenced this pull request Jul 5, 2023

Revert "feat: adding gh action for spelling errors (#1174)"

0371cdd

This reverts commit bb7aa7b.

rupali-codes added a commit that referenced this pull request Jul 5, 2023

Revert "feat: adding gh action for spelling errors (#1174)" (#1228)

add04be

This reverts commit bb7aa7b.

k-deepak04 mentioned this pull request Aug 4, 2023

Spellcheck #1493

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Addiing gh action for spelling errors #1174

Addiing gh action for spelling errors #1174

CBID2 commented Jun 27, 2023 •

edited

Loading

vercel bot commented Jun 27, 2023 •

edited

Loading

github-actions bot left a comment

saikiranreddy201 commented Jun 27, 2023

CBID2 commented Jun 27, 2023

saikiranreddy201 commented Jun 27, 2023

CBID2 commented Jun 27, 2023

ujjawaltyagii commented Jun 29, 2023

CBID2 commented Jun 29, 2023

rupali-codes commented Jun 29, 2023

CBID2 commented Jun 29, 2023

CBID2 commented Jun 30, 2023

k-deepak04 commented Jun 30, 2023

CBID2 commented Jul 1, 2023 •

edited

Loading

k-deepak04 commented Jul 1, 2023

rupali-codes commented Jul 1, 2023

CBID2 commented Jul 1, 2023

k-deepak04 commented Jul 2, 2023

rupali-codes commented Jul 2, 2023

CBID2 left a comment

CBID2 commented Jul 2, 2023

rupali-codes left a comment

CBID2 commented Jul 3, 2023

rupali-codes commented Jul 4, 2023

CBID2 commented Jul 4, 2023

k-deepak04 commented Aug 4, 2023

k-deepak04 commented Aug 4, 2023

CBID2 commented Aug 4, 2023

Addiing gh action for spelling errors #1174

Addiing gh action for spelling errors #1174

Conversation

CBID2 commented Jun 27, 2023 • edited Loading

Fixes Issue

Changes proposed

Screenshots

Note to reviewers

vercel bot commented Jun 27, 2023 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

saikiranreddy201 commented Jun 27, 2023

CBID2 commented Jun 27, 2023

saikiranreddy201 commented Jun 27, 2023

CBID2 commented Jun 27, 2023

ujjawaltyagii commented Jun 29, 2023

CBID2 commented Jun 29, 2023

rupali-codes commented Jun 29, 2023

CBID2 commented Jun 29, 2023

CBID2 commented Jun 30, 2023

k-deepak04 commented Jun 30, 2023

CBID2 commented Jul 1, 2023 • edited Loading

k-deepak04 commented Jul 1, 2023

rupali-codes commented Jul 1, 2023

CBID2 commented Jul 1, 2023

k-deepak04 commented Jul 2, 2023

rupali-codes commented Jul 2, 2023

CBID2 left a comment

Choose a reason for hiding this comment

CBID2 commented Jul 2, 2023

rupali-codes left a comment

Choose a reason for hiding this comment

CBID2 commented Jul 3, 2023

rupali-codes commented Jul 4, 2023

CBID2 commented Jul 4, 2023

k-deepak04 commented Aug 4, 2023

k-deepak04 commented Aug 4, 2023

CBID2 commented Aug 4, 2023

CBID2 commented Jun 27, 2023 •

edited

Loading

vercel bot commented Jun 27, 2023 •

edited

Loading

CBID2 commented Jul 1, 2023 •

edited

Loading