Handle CXCursor_LinkageSpec in Clang 18+ #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 1, 2023
… r=emilio,supply-chain-reviewers Differential Revision: https://phabricator.services.mozilla.com/D195060
aosmond
pushed a commit
to aosmond/gecko
that referenced
this pull request
Dec 1, 2023
… r=emilio,supply-chain-reviewers Differential Revision: https://phabricator.services.mozilla.com/D195060
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 7, 2023
… r=emilio,supply-chain-reviewers Differential Revision: https://phabricator.services.mozilla.com/D195060 UltraBlame original commit: 160bfd7365875ceea03d8b499ea08ee9051d9239
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 7, 2023
… r=emilio,supply-chain-reviewers Differential Revision: https://phabricator.services.mozilla.com/D195060 UltraBlame original commit: 160bfd7365875ceea03d8b499ea08ee9051d9239
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 7, 2023
… r=emilio,supply-chain-reviewers Differential Revision: https://phabricator.services.mozilla.com/D195060 UltraBlame original commit: 160bfd7365875ceea03d8b499ea08ee9051d9239
pld-gitsync
pushed a commit
to pld-linux/thunderbird
that referenced
this pull request
Apr 17, 2024
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
extern "C"clause. llvm/llvm-project#56687Past versions of Clang have a longstanding bug (11+ years; see https://stackoverflow.com/questions/11865486/clang-ast-extern-linkagespec-issue) of
clang::getCursorKindForDeclreporting linkage specifications such asextern "C"as CXCursor_UnexposedDecl, rather than CXCursor_LinkageSpec.This was recently fixed in Clang 18, which breaks bindgen by making all
extern "C"decls invisible to bindgen. Bindgen just generates nothing.This PR makes bindgen compatible with Clang 18 by treating CXCursor_LinkageSpec the same as the old CXCursor_UnexposedDecl.