[1.93.1] Revert "Update wasm-related dependencies in CI"#152259
Closed
alexcrichton wants to merge 1 commit intorust-lang:stablefrom
Closed
[1.93.1] Revert "Update wasm-related dependencies in CI"#152259alexcrichton wants to merge 1 commit intorust-lang:stablefrom
alexcrichton wants to merge 1 commit intorust-lang:stablefrom
Conversation
This reverts commit 4c6e41c.
Collaborator
|
r? @jieyouxu rustbot has assigned @jieyouxu. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
Member
Author
|
Some more discussion of this backport is at #t-release > 1.93.1 @ 💬 |
Collaborator
|
A job failed! Check out the build log: (web) (plain enhanced) (plain) Click to see the possible cause of the failure (guessed by this bot) |
Member
|
Stable nomination thread for T-compiler: #t-compiler/backports > #152259: stable-nominated |
Member
|
This is included in #152450, thanks! |
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
[stable] prepare Rust 1.93.1 This includes the following backported fixes: - Don't try to recover keyword as non-keyword identifier #150590 - Fix `panicking_unwrap` FP on field access with implicit deref rust-lang/rust-clippy#16196 - Revert "Update wasm-related dependencies in CI" #152259 And these are just to avoid recent CI issues: - Remove rustdoc GUI flaky test #152116 - Remove the 4 failing tests from rustdoc-gui #152194 r? @rust-lang/release @rustbot ping relnotes-interest-group
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 11, 2026
[stable] prepare Rust 1.93.1 This includes the following backported fixes: - Don't try to recover keyword as non-keyword identifier #150590 - Fix `panicking_unwrap` FP on field access with implicit deref rust-lang/rust-clippy#16196 - Revert "Update wasm-related dependencies in CI" #152259 And these are just to avoid recent CI issues: - Remove rustdoc GUI flaky test #152116 - Remove the 4 failing tests from rustdoc-gui #152194 r? @rust-lang/release @rustbot ping relnotes-interest-group
2 tasks
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this pull request
Feb 14, 2026
Pkgsrc changes: * drop dependency on compat80 for some targets (no longer applicable) * re-enable armv7 in the do-cross.mk file. Upstream changes: Version 1.93.1 (2026-02-12) =========================== - [Don't try to recover keyword as non-keyword identifier] (rust-lang/rust#150590), fixing an ICE that especially [affected rustfmt] (rust-lang/rustfmt#6739). - [Fix `clippy::panicking_unwrap` false-positive on field access with implicit deref] (rust-lang/rust-clippy#16196). - [Revert "Update wasm-related dependencies in CI"] (rust-lang/rust#152259), fixing file descriptor leaks on the `wasm32-wasip2` target.
bialy69-git
approved these changes
Feb 15, 2026
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Feb 15, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [rust](https://github.com/rust-lang/rust) | patch | `1.93.0` → `1.93.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>rust-lang/rust (rust)</summary> ### [`v1.93.1`](https://github.com/rust-lang/rust/blob/HEAD/RELEASES.md#Version-1931-2026-02-12) [Compare Source](rust-lang/rust@1.93.0...1.93.1) \=========================== <a id="1.93.1"></a> - [Don't try to recover keyword as non-keyword identifier](rust-lang/rust#150590), fixing an ICE that especially [affected rustfmt](rust-lang/rustfmt#6739). - [Fix `clippy::panicking_unwrap` false-positive on field access with implicit deref](rust-lang/rust-clippy#16196). - [Revert "Update wasm-related dependencies in CI"](rust-lang/rust#152259), fixing file descriptor leaks on the `wasm32-wasip2` target. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMC4zIiwidXBkYXRlZEluVmVyIjoiNDMuMTAuMyIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 4c6e41c which was #149037. The purpose of this revert is to fix #152255. This bug is present for Rust 1.93.0 and no other releases of Rust. For example beta/1.94.0 is not affected (for a sort of weird confluence of events reasons).
The specific change here is that the wasi-libc bundled with the
wasm32-wasip{1,2}targets, as shipped by rustup, is downgraded from wasi-sdk-29 to wasi-sdk-27. The changelog for these two tags is relatively modest, but there were major differences in the submodules. The LLVM submodule of wasi-sdk was updated from LLVM 20 to LLVM 21, but this only affects the compiled output. There were no known bugs with LLVM 20 and so this is not known to have affected the compiled artifact of wasi-libc much.The main update of wasi-sdk-27 to wasi-sdk-29, however, is a very large amount of changes in wasi-libc, which directly affects what rustc is shipping. Most of these changes are in the bucket of "port the
wasm32-wasip2target to using WASIp2 APIs directly". This is the source of the bug in #152255 since rustc was half-using wasi-libc and half-using WASIp1 directly. Functionality-wise wasi-libc did not change all that much, however. The migration to WASIp2 APIs directly is intended to be behavior neutral, for example. Inevitably there were small behavioral changes in wasi-libc, some intentional and some unintentional. For example randomness in wasi-libc calls the host less in 27 and more in 29 and a bug related to thepollfunction was fixed in 29.Overall my personal opinion is that while it's theoretically possible to break users of Rust 1.93 who are relying on the update to wasi-sdk-29 we'll instead fix more users by reverting this update. Not reverting this update means that dropping a
std::fs::Filedoesn't actually do anything and thus wasm components can easily exhaust the file descriptor limit.In summary:
wasm32-wasip2target alone due to Update wasm-related dependencies in CI #149037unix.rscode on WASI targets #147572)Fixes #152255