Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function/variable #358

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Remove unused function/variable #358

merged 1 commit into from
Feb 1, 2024

Conversation

ojousima
Copy link
Member

@ojousima ojousima commented Feb 1, 2024

No description provided.

Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ojousima ojousima merged commit 2778a3f into master Feb 1, 2024
5 checks passed
@ojousima ojousima deleted the remove-dead-code branch February 1, 2024 15:38
Copy link
Contributor

@DG12 DG12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is PVS Studio no longer to be used?

@ojousima
Copy link
Member Author

ojousima commented Feb 5, 2024

Is PVS Studio no longer to be used?

Yes, PVS Studio changed their licensing for open source and we do not match their terms anymore.

Copy link
Contributor

@DG12 DG12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I liked boot_count, I thought it was informative especially useful when tag was crashing in a loop.

Why didn't you like it?

@ojousima
Copy link
Member Author

ojousima commented Feb 6, 2024

Why didn't you like it?

There is no practical way for users to read it out without devkit, and it's hard even with devkit. Since it's not used in production it is bit unnecessary, and the way nRF filesystem works clutters up the flash page. Data is not replaced, it's written as "not valid" and new element is added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants