Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused function/variable #358

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Remove unused function/variable #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions .github/workflows/gh-pages-push.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,26 +40,6 @@ jobs:
exit 1
fi

- name: Install PVS Studio
run: |
wget -q -O - https://files.viva64.com/etc/pubkey.txt | sudo apt-key add -
sudo wget https://files.viva64.com/etc/viva64.list -O /etc/apt/sources.list.d/viva64.list
sudo apt-get update -qq && sudo apt-get install --assume-yes --quiet gcc-multilib && sudo apt-get install -qq
sudo apt-get install -qq pvs-studio
pvs-studio-analyzer credentials ${{ secrets.PVS_USERNAME }} ${{ secrets.PVS_KEY }}

- name: Run PVS Studio
run: make pvs

# Error if pvs.error has content
- name: Check PVS has no errors
run: |
if [[ $(wc -l <doxygen.error) -gt 1 ]]
then
cat pvs.error
exit 1
fi

- name: Install SSH Client 🔑
uses: webfactory/ssh-agent@v0.5.2
with:
Expand Down
5 changes: 4 additions & 1 deletion src/app_log.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ m_log_output_block; //!< Block read from flash for examination.
TESTABLE_STATIC app_log_config_t m_log_config; //!< Configuration for logging.
TESTABLE_STATIC uint64_t
m_last_sample_ms; //!< Timestamp of last processed sample.
TESTABLE_STATIC uint32_t m_boot_count = 0;


/*
Expand Down Expand Up @@ -127,6 +126,9 @@ static rd_status_t purge_logs (void)
return err_code;
}

#if 0
// Bootcounter is unused, code left for reference.
TESTABLE_STATIC uint32_t m_boot_count = 0;
TESTABLE_STATIC rd_status_t app_log_increment_boot_count (void)
{
rd_status_t err_code = RD_SUCCESS;
Expand All @@ -147,6 +149,7 @@ TESTABLE_STATIC rd_status_t app_log_increment_boot_count (void)
LOGI (msg);
return err_code;
}
#endif

rd_status_t app_log_init (void)
{
Expand Down
Loading