Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Irregular-spaced shoreline position computation #55

Merged
merged 5 commits into from
May 1, 2021

Conversation

amoodie
Copy link
Contributor

@amoodie amoodie commented Apr 28, 2021

A function to compute the mean and std dev to the shoreline. This method uses irregular sampling, which makes it relatively straightforward and computationally efficient, but it may not always match user intuition (for example in the presence of an estuary).

I have opened an issue to create a companion function that implements a regular sampling approach (#57).

Todo

  • docs
  • tests

@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #55 (1fcdd85) into develop (626928b) will increase coverage by 0.15%.
The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #55      +/-   ##
===========================================
+ Coverage    87.33%   87.48%   +0.15%     
===========================================
  Files            9        9              
  Lines         2400     2445      +45     
===========================================
+ Hits          2096     2139      +43     
- Misses         304      306       +2     
Impacted Files Coverage Δ
deltametrics/plan.py 86.93% <92.30%> (+0.30%) ⬆️
deltametrics/plot.py 89.52% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 626928b...1fcdd85. Read the comment docs.

@amoodie amoodie requested a review from elbeejay April 29, 2021 20:09
@amoodie amoodie changed the title Shoreline position Irregular-spaced shoreline position computation Apr 29, 2021
Copy link
Contributor

@elbeejay elbeejay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the exception of the return portion of the doc-string this looks good to me.

I fiddled with using scipy.ndimage.distance_transform_edt() to calculate distances instead of the method implemented here but my alternative implementations were consistently slower.

deltametrics/plan.py Outdated Show resolved Hide resolved
@amoodie amoodie merged commit e031990 into sandpiper-toolchain:develop May 1, 2021
@amoodie amoodie deleted the shoreline_position branch March 20, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants