Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API URL Update & Error Message fix #17

Merged
merged 3 commits into from
Jul 25, 2024
Merged

API URL Update & Error Message fix #17

merged 3 commits into from
Jul 25, 2024

Conversation

gtrbunny
Copy link
Contributor

@gtrbunny gtrbunny commented Jul 24, 2024

  • API URL update, as notified by email by Ship&Co on 23/July/2024. Must be updated by Friday 6/Sep/2024.
  • Minor update for avoiding a crash when handling errors without a message

This PR:

  • Adds a new feature ...
  • Covered by tests
  • Fixes #nnnn

@@ -57,7 +57,7 @@ final class ClientBuilder implements LoggerAwareInterface

private const DEFAULT_TIMEOUT = 60;

private const STANDARD_BASE_URL = 'https://app.shipandco.com';
private const STANDARD_BASE_URL = 'https://api.shipandco.com';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanmai sanmai enabled auto-merge July 25, 2024 07:46
@sanmai sanmai merged commit e533707 into sanmai:main Jul 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants