Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API URL Update & Error Message fix #17

Merged
merged 3 commits into from
Jul 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ClientBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ final class ClientBuilder implements LoggerAwareInterface

private const DEFAULT_TIMEOUT = 60;

private const STANDARD_BASE_URL = 'https://app.shipandco.com';
private const STANDARD_BASE_URL = 'https://api.shipandco.com';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


private const PACKAGE_NAME = 'ShipAndCo-SDK';
private const VERSION_INFO = '$Format:%h%d by %an +%ae$';
Expand Down
2 changes: 1 addition & 1 deletion src/Requests/AddressesRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ final class AddressesRequest implements Request
use RequestCore;

private const METHOD = 'GET';
private const ADDRESS = '/api/v1/addresses';
private const ADDRESS = '/v1/addresses';
private const RESPONSE = AddressesResponse::class;
}
2 changes: 1 addition & 1 deletion src/Requests/CarriersRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ final class CarriersRequest implements Request
use RequestCore;

private const METHOD = 'GET';
private const ADDRESS = '/api/v1/carriers';
private const ADDRESS = '/v1/carriers';
private const RESPONSE = CarriersResponse::class;
}
2 changes: 1 addition & 1 deletion src/Requests/CreateShipmentRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ final class CreateShipmentRequest implements JsonRequest
use ShipmentFields;

private const METHOD = 'POST';
private const ADDRESS = '/api/v1/shipments';
private const ADDRESS = '/v1/shipments';
private const RESPONSE = ShipmentResponse::class;
}
2 changes: 1 addition & 1 deletion src/Requests/RatesRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,6 @@ final class RatesRequest implements JsonRequest
use ShipmentFields;

private const METHOD = 'POST';
private const ADDRESS = '/api/v1/rates';
private const ADDRESS = '/v1/rates';
private const RESPONSE = RatesResponse::class;
}
2 changes: 1 addition & 1 deletion src/Requests/WarehousesRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,6 @@ final class WarehousesRequest implements Request
use RequestCore;

private const METHOD = 'GET';
private const ADDRESS = '/api/v1/addresses';
private const ADDRESS = '/v1/addresses';
private const RESPONSE = AddressesResponse::class;
}
2 changes: 1 addition & 1 deletion src/Responses/Bad/ErrorResponse/Detail.php
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,6 @@ public function getErrorCode(): ?string

public function getMessage(): string
{
return $this->message;
return $this->message ?? '';
}
}
Loading