-
Notifications
You must be signed in to change notification settings - Fork 924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp CI checks #9538
Merged
Merged
Revamp CI checks #9538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set value to "true"
This reverts commit d669d9d.
commit a0de550 Author: roi-meir <meir.roi@gmail.com> Date: Mon Sep 30 14:22:13 2024 +0300 Remove env step commit 9884669 Author: roi-meir <meir.roi@gmail.com> Date: Mon Sep 30 14:05:14 2024 +0300 Move new env under global section commit ab6cf2d Author: roi-meir <meir.roi@gmail.com> Date: Mon Sep 30 14:04:51 2024 +0300 Remove R_LIBCURL_SSL_REVOKE_BEST_EFFORT from travis config commit 53a258d Author: roi-meir <meir.roi@gmail.com> Date: Mon Sep 30 13:56:48 2024 +0300 Fix CURL_SSL_BACKEND env commit 215775c Author: roi-meir <meir.roi@gmail.com> Date: Mon Sep 30 13:52:46 2024 +0300 Try setting CURL_SSL_BACKEND to openssl commit 680f83c Author: roi-meir <meir.roi@gmail.com> Date: Mon Sep 30 12:36:02 2024 +0300 Try to see the current env to see if R_LIBCURL_SSL_REVOKE_BEST_EFFORT is supplied correctly commit 13e055b Author: roi-meir <meir.roi@gmail.com> Date: Mon Sep 30 11:33:40 2024 +0300 Remove test travis step commit 92d5f5f Author: roi-meir <meir.roi@gmail.com> Date: Mon Sep 30 11:20:03 2024 +0300 Check that appveyor is using the branch configuration commit e3c193f Author: roi-meir <meir.roi@gmail.com> Date: Mon Sep 30 11:13:52 2024 +0300 Set R_LIBCURL_SSL_REVOKE_BEST_EFFORT in travis.yml commit 710bab4 Author: roi-meir <meir.roi@gmail.com> Date: Mon Sep 30 11:08:24 2024 +0300 Move R_LIBCURL_SSL_REVOKE_BEST_EFFORT environment variable outside of global section commit b1d8d51 Author: roi-meir <meir.roi@gmail.com> Date: Mon Sep 30 10:35:42 2024 +0300 Set R_LIBCURL_SSL_REVOKE_BEST_EFFORT to TRUE in string commit 2701bc2 Author: roi-meir <meir.roi@gmail.com> Date: Mon Sep 30 10:13:31 2024 +0300 SET R_LIBCURL_SSL_REVOKE_BEST_EFFORT to TRUE in appveyor script Deal with ssl problem in bioc_install command
This was referenced Dec 11, 2024
rsatija
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces basic CI checks for
Seurat
. The implementation uses a Docker-based GitHub Action, nearly identical to the one added forSeuratObject
in:For more details on the underlying Docker image see:
satijalab/seurat-ci
Image seurat-docker#4The workflow:
satijalab/seurat-ci
image from DockerHub.Seurat
.rcmdcheck
(tests are skipped).Seurat
viatestthat::test_local
The workflow is currently failing, which is expected. I will follow up soon with fixes for:
and
Once the WARNING is resolved I will update the branch rules for
develop
to require that theIntegration Checks: check-package
job passes for PRs to be merged. We'll still need to review the output of the check manually to make sure that no problematic NOTES are being thrown.It looks like the
enrichR
package was recently removed from CRAN, which is causing the following NOTE:The package’s author is aware of the issue—a fix has been merged—and they’ve indicated that they’ll be re-submitting to CRAN soon. However, until that happens, we'll be blocked from cutting our own release.
This PR also:
and
packages as suggested dependencies.true
.We'll temporarily leave the AppVeyor pipeline in place so that we can compare their outputs. The new pipeline should be stricter than the old, but we might as well verify this over the next few PRs we merge. Eventually, I'll push a follow-up change dropping the AppVeyor pipeline as well.
I've made similar DESCRIPTION updates for
SeuratObject
, for more details see: