Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(spinner): add darkmode and lightmode screenshot tests and modify existing tests #924

Closed
wants to merge 2 commits into from

Conversation

max-umain
Copy link
Collaborator

@max-umain max-umain commented Dec 17, 2024

Describe pull-request

Adds darkmode and lightmode screenshot tests for the spinner component, and modifies existing tests and folder structure.

Issue Linking:

How to test

Provide detailed steps for testing, including any necessary setup.

  1. Run npm run test
  2. Visually inspect the files generated by the tests

Checklist before submission

  • I have added unit tests for my changes (if applicable)
  • All existing tests pass
  • I have updated the documentation (if applicable)
  • Not breaking production behavior
  • Behavior available in storybook with documented descriptions (if applicable)
  • npm run build-all without errors

Suggested test steps

  • Browser testing (Chrome, Safari, Firefox)
  • Keyboard operability
  • Interactive elements have labels.
  • Storybook controls
  • Design/controls/props is aligned with other components
  • Dark/light mode and variants
  • Input fields – values should be displayed properly
  • Events

Screenshots

Not applicable

Additional context

None

Copy link
Contributor

Playwright test results

passed  420 passed
skipped  1 skipped

Details

stats  421 tests across 147 suites
duration  59.6 seconds
commit  ca417e0

Skipped tests

src/components/table/table/test/expandable-row-autocollapse/expandable-row-autocollapse.e2e.ts › tds-table-expandable-row-autoCollapse › NEEDS FIXING: expanding one row collapses the others when autoCollapse is true

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-924.d3fazya28914g3.amplifyapp.com

@max-umain max-umain closed this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants