Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(spinner): add darkmode and lightmode screenshot tests and modify existing tests #924

Closed
wants to merge 2 commits into from
Closed

test(spinner): add darkmode and lightmode screenshot tests and modify existing tests #924

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dcf97e
test(spinner): add darkmode and lightmode tests, refactor and modify …
max-umain Dec 17, 2024
ca417e0
test(spinner): refactor tests to use beforeEach for page navigation
max-umain Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/core/src/components/spinner/test/inverted/darkmode/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!DOCTYPE html>
<html lang="en" dir="ltr">
<head>
<meta charset="UTF-8" />
<title>Spinner - Standard</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0" />
<link rel="stylesheet" href="../../../../../../dist/tegel/tegel.css" />
<script type="module">
import { defineCustomElements } from '../../../../../../loader/index.es2017.js';
defineCustomElements();
</script>
</head>

<body class="tds-mode-dark" style="background-color: var(--tds-grey-958)">
<tds-spinner size="lg" variant="inverted"></tds-spinner>
<tds-spinner size="md" variant="inverted"></tds-spinner>
<tds-spinner size="sm" variant="inverted"></tds-spinner>
<tds-spinner size="xs" variant="inverted"></tds-spinner>
</body>
</html>
8 changes: 5 additions & 3 deletions ...ents/spinner/test/inverted/spinner.e2e.ts → ...ner/test/inverted/darkmode/spinner.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import { test } from 'stencil-playwright';
import { expect } from '@playwright/test';

const componentTestPath = 'src/components/spinner/test/inverted/index.html';
const componentTestPath = 'src/components/spinner/test/inverted/darkmode/index.html';

test.describe.parallel('tds-spinner-inverted', () => {
test('renders inverted spinner correctly', async ({ page }) => {
test.describe.parallel('tds-spinner-inverted-darkmode', () => {
test.beforeEach(async ({ page }) => {
await page.goto(componentTestPath);
});

test('renders inverted spinner correctly', async ({ page }) => {
/* Check diff on screenshot */
await expect(page).toHaveScreenshot({ maxDiffPixels: 0 });
});
Expand Down
0 ...rs-inverted-spinner-correctly-1-linux.png → ...rs-inverted-spinner-correctly-1-linux.png
View file
Open in desktop
File renamed without changes
6 changes: 3 additions & 3 deletions ...mponents/spinner/test/inverted/index.html → ...pinner/test/inverted/lightmode/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@
<meta charset="UTF-8" />
<title>Spinner - Standard</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0" />
<link rel="stylesheet" href="../../../../../dist/tegel/tegel.css" />
<link rel="stylesheet" href="../../../../../../dist/tegel/tegel.css" />
<script type="module">
import { defineCustomElements } from '../../../../../loader/index.es2017.js';
import { defineCustomElements } from '../../../../../../loader/index.es2017.js';
defineCustomElements();
</script>
</head>

<body class="tds-mode-dark">
<body style="background-color: var(--tds-grey-50)">
<tds-spinner size="lg" variant="inverted"></tds-spinner>
<tds-spinner size="md" variant="inverted"></tds-spinner>
<tds-spinner size="sm" variant="inverted"></tds-spinner>
Expand Down
15 changes: 15 additions & 0 deletions packages/core/src/components/spinner/test/inverted/lightmode/spinner.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { test } from 'stencil-playwright';
import { expect } from '@playwright/test';

const componentTestPath = 'src/components/spinner/test/inverted/lightmode/index.html';

test.describe.parallel('tds-spinner-inverted-lightmode', () => {
test.beforeEach(async ({ page }) => {
await page.goto(componentTestPath);
});

test('renders inverted spinner correctly', async ({ page }) => {
/* Check diff on screenshot */
await expect(page).toHaveScreenshot({ maxDiffPixels: 0 });
});
});
Binary file added ...s/tds-spinner-inverted-lightmode-renders-inverted-spinner-correctly-1-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
20 changes: 20 additions & 0 deletions packages/core/src/components/spinner/test/standard/darkmode/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<!DOCTYPE html>
<html lang="en" dir="ltr">
<head>
<meta charset="UTF-8" />
<title>Spinner - Standard</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0" />
<link rel="stylesheet" href="../../../../../../dist/tegel/tegel.css" />
<script type="module">
import { defineCustomElements } from '../../../../../../loader/index.es2017.js';
defineCustomElements();
</script>
</head>

<body class="tds-mode-dark" style="background-color: var(--tds-grey-958)">
<tds-spinner size="lg" variant="standard"></tds-spinner>
<tds-spinner size="md" variant="standard"></tds-spinner>
<tds-spinner size="sm" variant="standard"></tds-spinner>
<tds-spinner size="xs" variant="standard"></tds-spinner>
</body>
</html>
15 changes: 15 additions & 0 deletions packages/core/src/components/spinner/test/standard/darkmode/spinner.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { test } from 'stencil-playwright';
import { expect } from '@playwright/test';

const componentTestPath = 'src/components/spinner/test/standard/darkmode/index.html';

test.describe.parallel('tds-spinner-standard-darkmode', () => {
test.beforeEach(async ({ page }) => {
await page.goto(componentTestPath);
});

test('renders basic spinner correctly', async ({ page }) => {
/* Check diff on screenshot */
await expect(page).toHaveScreenshot({ maxDiffPixels: 0 });
});
});
Binary file added ...shots/tds-spinner-standard-darkmode-renders-basic-spinner-correctly-1-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions ...mponents/spinner/test/standard/index.html → ...pinner/test/standard/lightmode/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,14 @@
<meta charset="UTF-8" />
<title>Spinner - Standard</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0, minimum-scale=1.0" />
<link rel="stylesheet" href="../../../../../dist/tegel/tegel.css" />
<link rel="stylesheet" href="../../../../../../dist/tegel/tegel.css" />
<script type="module">
import { defineCustomElements } from '../../../../../loader/index.es2017.js';
import { defineCustomElements } from '../../../../../../loader/index.es2017.js';
defineCustomElements();
</script>
</head>

<body>
<body style="background-color: var(--tds-grey-50)">
<tds-spinner size="lg" variant="standard"></tds-spinner>
<tds-spinner size="md" variant="standard"></tds-spinner>
<tds-spinner size="sm" variant="standard"></tds-spinner>
Expand Down
10 changes: 5 additions & 5 deletions ...ents/spinner/test/standard/spinner.e2e.ts → ...er/test/standard/lightmode/spinner.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
import { test } from 'stencil-playwright';
import { expect } from '@playwright/test';

const componentTestPath = 'src/components/spinner/test/standard/index.html';
const componentTestPath = 'src/components/spinner/test/standard/lightmode/index.html';

test.describe.parallel('tds-spinner-standard', () => {
test('renders basic spinner correctly', async ({ page }) => {
test.describe.parallel('tds-spinner-standard-lightmode', () => {
test.beforeEach(async ({ page }) => {
await page.goto(componentTestPath);
});

test('renders basic spinner correctly', async ({ page }) => {
/* Check diff on screenshot */
await expect(page).toHaveScreenshot({ maxDiffPixels: 0 });
});

test('Check if animation is present', async ({ page }) => {
await page.goto(componentTestPath);

const spinner = page.locator('tds-spinner:first-child circle');
const spinnerStyle = await spinner.evaluate((style) => getComputedStyle(style).animationName);
expect(spinnerStyle).toBe('dash');
Expand Down
Binary file added ...hots/tds-spinner-standard-lightmode-renders-basic-spinner-correctly-1-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed ...e.ts-snapshots/tds-spinner-standard-renders-basic-spinner-correctly-1-linux.png
View file
Open in desktop
Binary file not shown.
Loading