-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: errors in existing cuda_kernels
#2877
fix: errors in existing cuda_kernels
#2877
Conversation
8724789
to
46eee73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the division-versus-modulus that you brought up in our last meeting, right?
(And also some kernels to remove. Certainly anything related to "identities" is obsolete.)
Yes! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ManasviGoyal - excellent! please, squash and merge if you have finished with it. Thanks!
This reverts commit 7687108.
Some minor fixes in some of the
cuda_kernels
.