Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump actions/upload-pages-artifact from 1 to 2 #2248

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 10, 2023

Bumps actions/upload-pages-artifact from 1 to 2.

Release notes

Sourced from actions/upload-pages-artifact's releases.

v2.0.0

Changelog

See details of all code changes since previous release.

v1.0.10

Changelog

See details of all code changes since previous release.

v1.0.9

Removed chmod as we moved towards trusting correct file permissions have been set. In the event this isn't the case then we raise an error in the action related to the file permissions.

v1.0.8

Changelog

See details of all code changes since previous release.

v1.0.7

Changelog

See details of all code changes since previous release.

v1.0.6

Changelog

See details of all code changes since previous release.

v1.0.5

Changelog

... (truncated)

Commits
  • a753861 Merge pull request #69 from actions/reapply-chmod-removal-for-v2
  • dca6bac Merge branch 'main' into reapply-chmod-removal-for-v2
  • 3138c05 Merge pull request #70 from actions/v2-docs-improvements
  • 07f501f Update README for v2
  • 9c071e6 Reapply PR #63 for v2
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/upload-pages-artifact](https://github.com/actions/upload-pages-artifact) from 1 to 2.
- [Release notes](https://github.com/actions/upload-pages-artifact/releases)
- [Commits](actions/upload-pages-artifact@v1...v2)

---
updated-dependencies:
- dependency-name: actions/upload-pages-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file github-actions labels Jul 10, 2023
@matthewfeickert matthewfeickert self-assigned this Jul 10, 2023
@matthewfeickert matthewfeickert added the chore Other changes that don't modify src or test files label Jul 10, 2023
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the file permissions fix covered in the README: https://github.com/actions/upload-pages-artifact/blob/a753861a5debcf57bf8b404356158c8e1e33150c/README.md#file-permissions

steps:
# ...
  - name: Fix permissions
    run: |
      chmod -c -R +rX "_site/" | while read line; do
        echo "::warning title=Invalid file permissions automatically fixed::$line"
      done
  - name: Upload Pages artifact
    uses: actions/upload-pages-artifact@v2
# ...

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (64346a8) 98.30% compared to head (625664e) 98.30%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2248   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4534     4534           
  Branches      802      802           
=======================================
  Hits         4457     4457           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 97.88% <ø> (ø)
doctest 61.09% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.11 96.31% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert added the need-to-backport tmp label until can be backported to patch release branch label Jul 11, 2023
@matthewfeickert matthewfeickert merged commit 4845a15 into main Jul 11, 2023
@matthewfeickert matthewfeickert deleted the dependabot/github_actions/actions/upload-pages-artifact-2 branch July 11, 2023 02:56
@matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label Jul 11, 2023
matthewfeickert added a commit that referenced this pull request Aug 16, 2023
* Backport components of:
   - PR #2103
   - PR #2237
   - PR #2248
   - PR #2254
   - PR #2275
@matthewfeickert matthewfeickert removed the need-to-backport tmp label until can be backported to patch release branch label Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Other changes that don't modify src or test files CI CI systems, GitHub Actions dependencies Pull requests that update a dependency file github-actions
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant