-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add devcontainer config #2250
Conversation
* Add devcontainer config using the pyhf Dockerfile. - c.f. https://containers.dev/
👋 @crazy4pi314 following your great ⚡ talk today and that things seemed pretty simple in bluesky/tiled#522 I wanted to try to get this going for |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2250 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 69 69
Lines 4534 4534
Branches 802 802
=======================================
Hits 4457 4457
Misses 45 45
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
.devcontainer/devcontainer.json
Outdated
"GitHub.codespaces", | ||
"ms-vscode-remote.remote-containers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let @crazy4pi314 give the final answer here, but my understanding is that those extensions are not actually necessary here, unless you want to connect to a remote container / codespace from inside the dev container (of course the extensions should not hurt either).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unless you want to connect to a remote container / codespace
While the pyhf dev team doesn't actively use Codespaces at the moment (very cool, but not clear if the cost is worth it atm for us) we would like for others to be able to use Codespaces or Gitpod for demos and to help people making contributions get onboarded. Do these extensions help / become needed there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I think they are probably not needed, Its likely my fault that I was exporting envs and those got installed as needed (but you don't have to proactively).
Gitpod I think has some very inital support for dev container config, so I am not sure if they would be helpful there yet :)
Thank you @crazy4pi314 and @ltalirz! 🚀 |
Description
@crazy4pi314, @guenp, and @ltalirz also gave the SciPy 2023 tutorial Meet your coding best friend: VS Code💖 - A hands-on tutorial on how to get the most out of the world’s most popular Python editor which covers dev containers in it as well: https://github.com/crazy4pi314/scipy-vscode-tutorial
Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: