Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add devcontainer config #2250

Merged
merged 2 commits into from
Jul 15, 2023
Merged

feat: Add devcontainer config #2250

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43b7cf2
feat: Add devcontainer config
matthewfeickert Jul 14, 2023
8daec08
Remove unused extensions
matthewfeickert Jul 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"name": "pyhf-devcontainer",
"build": {
"context": "..",
"dockerfile": "../docker/Dockerfile"
},
"features": {
"ghcr.io/devcontainers/features/git:1": {}
},

"customizations": {
"vscode": {
"settings": {
"python.defaultInterpreterPath": "/opt/venv/bin/python"
},
"extensions": [
"ms-python.python",
"ms-toolsai.jupyter",
"GitHub.codespaces",
"ms-vscode-remote.remote-containers"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll let @crazy4pi314 give the final answer here, but my understanding is that those extensions are not actually necessary here, unless you want to connect to a remote container / codespace from inside the dev container (of course the extensions should not hurt either).

Copy link
Member Author

@matthewfeickert matthewfeickert Jul 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unless you want to connect to a remote container / codespace

While the pyhf dev team doesn't actively use Codespaces at the moment (very cool, but not clear if the cost is worth it atm for us) we would like for others to be able to use Codespaces or Gitpod for demos and to help people making contributions get onboarded. Do these extensions help / become needed there?

Copy link

@crazy4pi314 crazy4pi314 Jul 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think they are probably not needed, Its likely my fault that I was exporting envs and those got installed as needed (but you don't have to proactively).

Gitpod I think has some very inital support for dev container config, so I am not sure if they would be helpful there yet :)

]
}
}
}