Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and fixes in dwiml_create_hdf5 and associated doc #222

Merged
merged 23 commits into from
Mar 4, 2024

Conversation

EmmaRenauld
Copy link
Collaborator

@EmmaRenauld EmmaRenauld commented Jan 15, 2024

Script dwiml_create_hdf5:

  • Removed option std_mask in the script. Is now an option of each volume group in the config file.
  • Fixed the spelling of "connectivty" in the code.
  • Small modif: use our io method add_logging_arg.

Script dwiml_compute_connectivity_from_labels:

  • Fixes.
  • Better figure.

Doc:

  • Add the std options explanation.
  • Add the connectivity options explanation.
  • Delete the preprocessing explanation. People know how to preprocess their data. (link to tractoflow is now deleted).

Sneeking in a .gitignore modification.

@pep8speaks
Copy link

pep8speaks commented Jan 15, 2024

Hello @EmmaRenauld, Thank you for updating !

Line 62:80: E501 line too long (80 > 79 characters)
Line 65:80: E501 line too long (80 > 79 characters)
Line 79:80: E501 line too long (80 > 79 characters)

Line 279:80: E501 line too long (80 > 79 characters)

Comment last updated at 2024-03-01 14:32:06 UTC

@EmmaRenauld
Copy link
Collaborator Author

See associated issue #223

@EmmaRenauld EmmaRenauld changed the title Update and fix script dwiml_create_hdf5 and associate documentation. Update and fixes in dwiml_create_hdf5 and associated doc Jan 30, 2024
@EmmaRenauld EmmaRenauld force-pushed the changes_biggest_database branch 2 times, most recently from 94dbe44 to 4fe5ab9 Compare February 28, 2024 13:17
@EmmaRenauld
Copy link
Collaborator Author

Ran at least two epochs on beluga on > 1 subject. Merging current state of code.

@EmmaRenauld EmmaRenauld merged commit bf8d2aa into scil-vital:master Mar 4, 2024
2 checks passed
@EmmaRenauld EmmaRenauld deleted the changes_biggest_database branch March 4, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants