-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no norm option to scil_bundle_fixel_analysis #1032
Merged
arnaudbore
merged 11 commits into
scilus:master
from
karanphil:add_no_norm_to_fixel_analysis
Nov 11, 2024
Merged
Add no norm option to scil_bundle_fixel_analysis #1032
arnaudbore
merged 11 commits into
scilus:master
from
karanphil:add_no_norm_to_fixel_analysis
Nov 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @karanphil, Thank you for updating !
Comment last updated at 2024-11-08 19:31:24 UTC |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1032 +/- ##
==========================================
+ Coverage 68.88% 68.94% +0.05%
==========================================
Files 434 434
Lines 22643 22657 +14
Branches 3077 3080 +3
==========================================
+ Hits 15598 15621 +23
+ Misses 5728 5724 -4
+ Partials 1317 1312 -5
|
arnaudbore
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost GTG
arnaudbore
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick description
This is a small PR to add the option of not normalizing the density maps. For instance, if you want to keep the information about the streamline count or the sift2 weight, you can now use
--norm none
. You can also use multiple choices like--norm voxel none
and it will produce outputs for both.The for loop on the norm options makes it look like all the code has changed in the script, but it is basically the same as before inside the loop, with shorter variable names to respect pep8.
Type of change
Enhancement
Check the relevant options.
Provide data, screenshots, command line to test (if relevant)
...
Checklist