Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no norm option to scil_bundle_fixel_analysis #1032

Merged
merged 11 commits into from
Nov 11, 2024

Conversation

karanphil
Copy link
Contributor

@karanphil karanphil commented Sep 30, 2024

Quick description

This is a small PR to add the option of not normalizing the density maps. For instance, if you want to keep the information about the streamline count or the sift2 weight, you can now use --norm none. You can also use multiple choices like --norm voxel none and it will produce outputs for both.

The for loop on the norm options makes it look like all the code has changed in the script, but it is basically the same as before inside the loop, with shorter variable names to respect pep8.

Type of change

Enhancement

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pep8speaks
Copy link

pep8speaks commented Sep 30, 2024

Hello @karanphil, Thank you for updating !

Line 79:1: W293 blank line contains whitespace

Comment last updated at 2024-11-08 19:31:24 UTC

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.94%. Comparing base (4bde487) to head (754cc96).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1032      +/-   ##
==========================================
+ Coverage   68.88%   68.94%   +0.05%     
==========================================
  Files         434      434              
  Lines       22643    22657      +14     
  Branches     3077     3080       +3     
==========================================
+ Hits        15598    15621      +23     
+ Misses       5728     5724       -4     
+ Partials     1317     1312       -5     
Components Coverage Δ
Scripts 69.68% <100.00%> (+0.09%) ⬆️
Library 67.91% <100.00%> (+0.01%) ⬆️

Copy link
Contributor

@arnaudbore arnaudbore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost GTG

@arnaudbore arnaudbore merged commit 8339116 into scilus:master Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants