Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Hyperplane update #1034

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

frheault
Copy link
Member

@frheault frheault commented Oct 2, 2024

Quick description

Attempt at having our improved RADTRACT Hyperplane subdivision !

image
https://www.ncbi.nlm.nih.gov/pmc/articles/PMC10246281/
...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pep8speaks
Copy link

pep8speaks commented Oct 2, 2024

Hello @frheault, Thank you for updating !

Line 6:80: E501 line too long (88 > 79 characters)
Line 102:80: E501 line too long (80 > 79 characters)
Line 139:80: E501 line too long (81 > 79 characters)
Line 258:80: E501 line too long (80 > 79 characters)
Line 275:80: E501 line too long (84 > 79 characters)

Line 192:80: E501 line too long (80 > 79 characters)
Line 273:80: E501 line too long (81 > 79 characters)

Comment last updated at 2024-10-18 19:22:59 UTC

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 81.10749% with 58 lines in your changes missing coverage. Please review.

Project coverage is 69.18%. Comparing base (1d6f848) to head (529646a).
Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1034      +/-   ##
==========================================
+ Coverage   68.78%   69.18%   +0.40%     
==========================================
  Files         429      432       +3     
  Lines       22265    22644     +379     
  Branches     3324     3069     -255     
==========================================
+ Hits        15314    15667     +353     
  Misses       5665     5665              
- Partials     1286     1312      +26     
Components Coverage Δ
Scripts 69.57% <68.57%> (-0.09%) ⬇️
Library 68.65% <84.81%> (+1.11%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants