Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: cut streamlines min length #1040

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

AntoineTheb
Copy link
Contributor

Quick description

Change the minimum length of streamlines output by scil_tractogram_cut_streamlines to 0, as the previous behavior was confusing.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • X ] My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (92a2010) to head (d4ba290).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1040   +/-   ##
=======================================
  Coverage   68.79%   68.79%           
=======================================
  Files         432      432           
  Lines       22456    22456           
  Branches     3038     3038           
=======================================
  Hits        15449    15449           
  Misses       5709     5709           
  Partials     1298     1298           
Components Coverage Δ
Scripts 69.66% <100.00%> (ø)
Library 67.56% <ø> (ø)

@arnaudbore arnaudbore merged commit b95593b into scilus:master Oct 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants