[ENH][BF] Update json conversion to excel used in tractometry_flow

[arnaudbore]

Quick description

Some scripts have been merged into scil_bundle_shape_measure.py because of that scil_json_convert_entries_to_xlsx was not able to do its job properly.

Best way to test this is to run tractometry_flow using this PR with local scilpy installation.

Type of change

Check the relevant options.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist

• My code follows the style guidelines of this project (run autopep8)
• I added relevant citations to scripts, modules and functions docstrings and descriptions
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I moved all functions from the script file (except the argparser and main) to scilpy modules
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[pep8speaks]

Hello @arnaudbore, Thank you for updating !

• In the file scripts/scil_bundle_shape_measures.py:

Line 263:80: E501 line too long (80 > 79 characters)
Line 271:78: W291 trailing whitespace
Line 273:80: E501 line too long (84 > 79 characters)
Line 274:80: E501 line too long (82 > 79 characters)

• In the file scripts/scil_json_convert_entries_to_xlsx.py:

Line 78:80: E501 line too long (98 > 79 characters)
Line 83:65: W291 trailing whitespace
Line 87:80: E501 line too long (89 > 79 characters)

Comment last updated at 2024-11-04 19:29:24 UTC

[frheault]

Minor comments, the tractometry flow PR was tested twice and the output looks great!

[codecov]

Codecov Report

Attention: Patch coverage is 38.00000% with 31 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (92a2010) to head (2a06733).
Report is 6 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1041   +/-   ##
=======================================
  Coverage   68.79%   68.79%           
=======================================
  Files         432      432           
  Lines       22456    22454    -2     
  Branches     3038     3041    +3     
=======================================
- Hits        15449    15448    -1     
+ Misses       5709     5706    -3     
- Partials     1298     1300    +2     

Components	Coverage Δ
Scripts	69.66% <38.00%> (+<0.01%)	⬆️
Library	67.56% <ø> (ø)

[frheault]

LGTM ! Ready to merge (did not know if you are 100%, if so go ahead)