-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: override config values use viper #1502
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1502 +/- ##
===========================================
- Coverage 51.71% 51.61% -0.10%
===========================================
Files 156 155 -1
Lines 12763 12771 +8
===========================================
- Hits 6600 6592 -8
- Misses 5595 5606 +11
- Partials 568 573 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Suggestion: use |
added a pr to try it. still a bit messy though. |
Purpose or design rationale of this PR
This PR aims to solve the bug when trying to override private key fields like
gas_oracle_sender_private_key
,commit_sender_private_key
.For now, the way we override config fields is based on the tag of JSON marshaller, but the real tag of those private keys are
json:"-"
, so here I propose to handle it specifically as a private key when the tag is-
.Didn't use
Viper
because seems that will involve quite amount of code changes.PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?