Skip to content

[Review Only] Landing livedev2 in core #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sebaslv wants to merge 4 commits into from
Closed

[Review Only] Landing livedev2 in core #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
81008e6
Move LiveDevelopment implementation to default
sebaslv Oct 29, 2014
3cdb26d
Align tests to new LiveDevelopment location
sebaslv Nov 3, 2014
139584f
add livedev2 under LiveDevelopment impls
sebaslv Oct 29, 2014
8fdfbdf
Add pref to allow switching LiveDevelopment impls
sebaslv Nov 3, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion src/LiveDevelopment/Agents/CSSAgent.js → ...elopment/impls/default/Agents/CSSAgent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ define(function CSSAgent(require, exports, module) {

var _ = require("thirdparty/lodash");

var Inspector = require("LiveDevelopment/Inspector/Inspector");
var Inspector = require("LiveDevelopment/impls/default/Inspector/Inspector");

/**
* Stylesheet details
Expand Down
2 changes: 1 addition & 1 deletion src/LiveDevelopment/Agents/ConsoleAgent.js → ...ment/impls/default/Agents/ConsoleAgent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
define(function ConsoleAgent(require, exports, module) {
"use strict";

var Inspector = require("LiveDevelopment/Inspector/Inspector");
var Inspector = require("LiveDevelopment/impls/default/Inspector/Inspector");

var _lastMessage; // {Console.ConsoleMessage} the last received message

Expand Down
8 changes: 4 additions & 4 deletions src/LiveDevelopment/Agents/DOMAgent.js → ...elopment/impls/default/Agents/DOMAgent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@ define(function DOMAgent(require, exports, module) {

var $exports = $(exports);

var Inspector = require("LiveDevelopment/Inspector/Inspector");
var EditAgent = require("LiveDevelopment/Agents/EditAgent");
var DOMNode = require("LiveDevelopment/Agents/DOMNode");
var DOMHelpers = require("LiveDevelopment/Agents/DOMHelpers");
var Inspector = require("LiveDevelopment/impls/default/Inspector/Inspector");
var EditAgent = require("LiveDevelopment/impls/default/Agents/EditAgent");
var DOMNode = require("LiveDevelopment/impls/default/Agents/DOMNode");
var DOMHelpers = require("LiveDevelopment/impls/default/Agents/DOMHelpers");

var _load; // {$.Deferred} load promise
var _idToNode; // {nodeId -> node}
Expand Down
0 src/LiveDevelopment/Agents/DOMHelpers.js → ...opment/impls/default/Agents/DOMHelpers.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/LiveDevelopment/Agents/DOMNode.js → ...velopment/impls/default/Agents/DOMNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
define(function DOMNodeModule(require, exports, module) {
"use strict";

var DOMHelpers = require("LiveDevelopment/Agents/DOMHelpers");
var DOMHelpers = require("LiveDevelopment/impls/default/Agents/DOMHelpers");

/** Fill a string to the given length (used for debug output)
* @param {string} source string
Expand Down
8 changes: 4 additions & 4 deletions src/LiveDevelopment/Agents/EditAgent.js → ...lopment/impls/default/Agents/EditAgent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@
define(function EditAgent(require, exports, module) {
"use strict";

var Inspector = require("LiveDevelopment/Inspector/Inspector");
var DOMAgent = require("LiveDevelopment/Agents/DOMAgent");
var RemoteAgent = require("LiveDevelopment/Agents/RemoteAgent");
var GotoAgent = require("LiveDevelopment/Agents/GotoAgent");
var Inspector = require("LiveDevelopment/impls/default/Inspector/Inspector");
var DOMAgent = require("LiveDevelopment/impls/default/Agents/DOMAgent");
var RemoteAgent = require("LiveDevelopment/impls/default/Agents/RemoteAgent");
var GotoAgent = require("LiveDevelopment/impls/default/Agents/GotoAgent");

var EditorManager = require("editor/EditorManager");

Expand Down
8 changes: 4 additions & 4 deletions src/LiveDevelopment/Agents/GotoAgent.js → ...lopment/impls/default/Agents/GotoAgent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ define(function GotoAgent(require, exports, module) {

require("utils/Global");

var Inspector = require("LiveDevelopment/Inspector/Inspector"),
DOMAgent = require("LiveDevelopment/Agents/DOMAgent"),
ScriptAgent = require("LiveDevelopment/Agents/ScriptAgent"),
RemoteAgent = require("LiveDevelopment/Agents/RemoteAgent"),
var Inspector = require("LiveDevelopment/impls/default/Inspector/Inspector"),
DOMAgent = require("LiveDevelopment/impls/default/Agents/DOMAgent"),
ScriptAgent = require("LiveDevelopment/impls/default/Agents/ScriptAgent"),
RemoteAgent = require("LiveDevelopment/impls/default/Agents/RemoteAgent"),
EditorManager = require("editor/EditorManager"),
CommandManager = require("command/CommandManager"),
Commands = require("command/Commands");
Expand Down
8 changes: 4 additions & 4 deletions src/LiveDevelopment/Agents/HighlightAgent.js → ...nt/impls/default/Agents/HighlightAgent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@
define(function HighlightAgent(require, exports, module) {
"use strict";

var DOMAgent = require("LiveDevelopment/Agents/DOMAgent"),
Inspector = require("LiveDevelopment/Inspector/Inspector"),
LiveDevelopment = require("LiveDevelopment/LiveDevelopment"),
RemoteAgent = require("LiveDevelopment/Agents/RemoteAgent"),
var DOMAgent = require("LiveDevelopment/impls/default/Agents/DOMAgent"),
Inspector = require("LiveDevelopment/impls/default/Inspector/Inspector"),
LiveDevelopment = require("LiveDevelopment/impls/default/LiveDevelopment"),
RemoteAgent = require("LiveDevelopment/impls/default/Agents/RemoteAgent"),
_ = require("thirdparty/lodash");

var _highlight = {}; // active highlight
Expand Down
2 changes: 1 addition & 1 deletion src/LiveDevelopment/Agents/NetworkAgent.js → ...ment/impls/default/Agents/NetworkAgent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
define(function NetworkAgent(require, exports, module) {
"use strict";

var Inspector = require("LiveDevelopment/Inspector/Inspector");
var Inspector = require("LiveDevelopment/impls/default/Inspector/Inspector");

var _urlRequested = {}; // url -> request info

Expand Down
6 changes: 3 additions & 3 deletions src/LiveDevelopment/Agents/RemoteAgent.js → ...pment/impls/default/Agents/RemoteAgent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ define(function RemoteAgent(require, exports, module) {

var $exports = $(exports);

var LiveDevelopment = require("LiveDevelopment/LiveDevelopment"),
Inspector = require("LiveDevelopment/Inspector/Inspector"),
RemoteFunctions = require("text!LiveDevelopment/Agents/RemoteFunctions.js");
var LiveDevelopment = require("LiveDevelopment/impls/default/LiveDevelopment"),
Inspector = require("LiveDevelopment/impls/default/Inspector/Inspector"),
RemoteFunctions = require("text!LiveDevelopment/impls/default/Agents/RemoteFunctions.js");

var _load; // deferred load
var _objectId; // the object id of the remote object
Expand Down
0 ...LiveDevelopment/Agents/RemoteFunctions.js → ...t/impls/default/Agents/RemoteFunctions.js
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions src/LiveDevelopment/Agents/ScriptAgent.js → ...pment/impls/default/Agents/ScriptAgent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
define(function ScriptAgent(require, exports, module) {
"use strict";

var Inspector = require("LiveDevelopment/Inspector/Inspector");
var DOMAgent = require("LiveDevelopment/Agents/DOMAgent");
var Inspector = require("LiveDevelopment/impls/default/Inspector/Inspector");
var DOMAgent = require("LiveDevelopment/impls/default/Agents/DOMAgent");

var _load; // the load promise
var _urlToScript; // url -> script info
Expand Down
6 changes: 3 additions & 3 deletions src/LiveDevelopment/Documents/CSSDocument.js → ...nt/impls/default/Documents/CSSDocument.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ define(function CSSDocumentModule(require, exports, module) {
"use strict";

var _ = require("thirdparty/lodash"),
CSSAgent = require("LiveDevelopment/Agents/CSSAgent"),
CSSAgent = require("LiveDevelopment/impls/default/Agents/CSSAgent"),
CSSUtils = require("language/CSSUtils"),
EditorManager = require("editor/EditorManager"),
HighlightAgent = require("LiveDevelopment/Agents/HighlightAgent"),
Inspector = require("LiveDevelopment/Inspector/Inspector");
HighlightAgent = require("LiveDevelopment/impls/default/Agents/HighlightAgent"),
Inspector = require("LiveDevelopment/impls/default/Inspector/Inspector");

/**
* @constructor
Expand Down
4 changes: 2 additions & 2 deletions ...ment/Documents/CSSPreprocessorDocument.js → ...ault/Documents/CSSPreprocessorDocument.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ define(function CSSPreprocessorDocumentModule(require, exports, module) {
var _ = require("thirdparty/lodash"),
CSSUtils = require("language/CSSUtils"),
EditorManager = require("editor/EditorManager"),
HighlightAgent = require("LiveDevelopment/Agents/HighlightAgent"),
Inspector = require("LiveDevelopment/Inspector/Inspector");
HighlightAgent = require("LiveDevelopment/impls/default/Agents/HighlightAgent"),
Inspector = require("LiveDevelopment/impls/default/Inspector/Inspector");

/**
* @constructor
Expand Down
8 changes: 4 additions & 4 deletions ...LiveDevelopment/Documents/HTMLDocument.js → ...t/impls/default/Documents/HTMLDocument.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,12 @@ define(function HTMLDocumentModule(require, exports, module) {
"use strict";

var EditorManager = require("editor/EditorManager"),
HighlightAgent = require("LiveDevelopment/Agents/HighlightAgent"),
HighlightAgent = require("LiveDevelopment/impls/default/Agents/HighlightAgent"),
HTMLInstrumentation = require("language/HTMLInstrumentation"),
Inspector = require("LiveDevelopment/Inspector/Inspector"),
LiveDevelopment = require("LiveDevelopment/LiveDevelopment"),
Inspector = require("LiveDevelopment/impls/default/Inspector/Inspector"),
LiveDevelopment = require("LiveDevelopment/impls/default/LiveDevelopment"),
PerfUtils = require("utils/PerfUtils"),
RemoteAgent = require("LiveDevelopment/Agents/RemoteAgent"),
RemoteAgent = require("LiveDevelopment/impls/default/Agents/RemoteAgent"),
_ = require("thirdparty/lodash");

/**
Expand Down
6 changes: 3 additions & 3 deletions src/LiveDevelopment/Documents/JSDocument.js → ...ent/impls/default/Documents/JSDocument.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@
define(function JSDocumentModule(require, exports, module) {
"use strict";

var Inspector = require("LiveDevelopment/Inspector/Inspector");
var ScriptAgent = require("LiveDevelopment/Agents/ScriptAgent");
var HighlightAgent = require("LiveDevelopment/Agents/HighlightAgent");
var Inspector = require("LiveDevelopment/impls/default/Inspector/Inspector");
var ScriptAgent = require("LiveDevelopment/impls/default/Agents/ScriptAgent");
var HighlightAgent = require("LiveDevelopment/impls/default/Agents/HighlightAgent");

/**
* @constructor
Expand Down
2 changes: 1 addition & 1 deletion src/LiveDevelopment/Inspector/Inspector.js → ...ment/impls/default/Inspector/Inspector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ define(function Inspector(require, exports, module) {
function init(theConfig) {
exports.config = theConfig;

var InspectorText = require("text!LiveDevelopment/Inspector/Inspector.json"),
var InspectorText = require("text!LiveDevelopment/impls/default/Inspector/Inspector.json"),
InspectorJSON = JSON.parse(InspectorText);

var i, j, domain, command;
Expand Down
0 src/LiveDevelopment/Inspector/Inspector.json → ...nt/impls/default/Inspector/Inspector.json
View file
Open in desktop
File renamed without changes.
0 src/LiveDevelopment/Inspector/inspector.html → ...nt/impls/default/Inspector/inspector.html
View file
Open in desktop
File renamed without changes.
0 src/LiveDevelopment/Inspector/jsdoc.rb → ...elopment/impls/default/Inspector/jsdoc.rb
View file
Open in desktop
File renamed without changes.
30 changes: 15 additions & 15 deletions src/LiveDevelopment/LiveDevelopment.js → ...elopment/impls/default/LiveDevelopment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,30 +94,30 @@ define(function LiveDevelopment(require, exports, module) {
UserServer = require("LiveDevelopment/Servers/UserServer").UserServer;

// Inspector
var Inspector = require("LiveDevelopment/Inspector/Inspector");
var Inspector = require("LiveDevelopment/impls/default/Inspector/Inspector");

// Documents
var CSSDocument = require("LiveDevelopment/Documents/CSSDocument"),
CSSPreprocessorDocument = require("LiveDevelopment/Documents/CSSPreprocessorDocument"),
HTMLDocument = require("LiveDevelopment/Documents/HTMLDocument"),
JSDocument = require("LiveDevelopment/Documents/JSDocument");
var CSSDocument = require("LiveDevelopment/impls/default/Documents/CSSDocument"),
CSSPreprocessorDocument = require("LiveDevelopment/impls/default/Documents/CSSPreprocessorDocument"),
HTMLDocument = require("LiveDevelopment/impls/default/Documents/HTMLDocument"),
JSDocument = require("LiveDevelopment/impls/default/Documents/JSDocument");

// Document errors
var SYNC_ERROR_CLASS = "live-preview-sync-error";

// Agents
var CSSAgent = require("LiveDevelopment/Agents/CSSAgent");
var CSSAgent = require("LiveDevelopment/impls/default/Agents/CSSAgent");

var agents = {
"console" : require("LiveDevelopment/Agents/ConsoleAgent"),
"remote" : require("LiveDevelopment/Agents/RemoteAgent"),
"network" : require("LiveDevelopment/Agents/NetworkAgent"),
"dom" : require("LiveDevelopment/Agents/DOMAgent"),
"console" : require("LiveDevelopment/impls/default/Agents/ConsoleAgent"),
"remote" : require("LiveDevelopment/impls/default/Agents/RemoteAgent"),
"network" : require("LiveDevelopment/impls/default/Agents/NetworkAgent"),
"dom" : require("LiveDevelopment/impls/default/Agents/DOMAgent"),
"css" : CSSAgent,
"script" : require("LiveDevelopment/Agents/ScriptAgent"),
"highlight" : require("LiveDevelopment/Agents/HighlightAgent"),
"goto" : require("LiveDevelopment/Agents/GotoAgent"),
"edit" : require("LiveDevelopment/Agents/EditAgent")
"script" : require("LiveDevelopment/impls/default/Agents/ScriptAgent"),
"highlight" : require("LiveDevelopment/impls/default/Agents/HighlightAgent"),
"goto" : require("LiveDevelopment/impls/default/Agents/GotoAgent"),
"edit" : require("LiveDevelopment/impls/default/Agents/EditAgent")
};

// construct path to launch.html
Expand All @@ -133,7 +133,7 @@ define(function LiveDevelopment(require, exports, module) {
// baseUrl is configured dynamically
launcherUrl = launcherUrl.replace("/test/SpecRunner.html", "/src/index.html");

launcherUrl = launcherUrl.substr(0, launcherUrl.lastIndexOf("/")) + "/LiveDevelopment/launch.html";
launcherUrl = launcherUrl.substr(0, launcherUrl.lastIndexOf("/")) + "/LiveDevelopment/impls/default/launch.html";
launcherUrl = window.location.origin + launcherUrl;

// Some agents are still experimental, so we don't enable them all by default
Expand Down
0 src/LiveDevelopment/launch.html → ...LiveDevelopment/impls/default/launch.html
View file
Open in desktop
File renamed without changes.
Loading