Closed
Conversation
In preparation for landing livedev2 as an alternative implementation, a folder /impls was created under LiveDevelopment folder and a the current implementation moved to a /default folder. Servers folder and LiveDevServerManager keep in their original location since they will be used as shared resources for both implementations.
Make tests run after moving LiveDevelopment to /impls/default
Add a working copy of the extension as part of Brackets core under LiveDevelopment/impls/livedev2. To make it work need to manually change reference at brackets.js when loading LiveDevelopment module. (/impls/default -> /impls/livedev2).
Add livedev.impl preference to let the user switch between 'default' and 'livedev2' implementations.
This was referenced Nov 3, 2014
Owner
Author
|
Closing in favor of #3 which makes copy of livedev2 files able to be reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial steps to land livedev2 in core. (#1 re-worked to make it more reviewable)
@busykai, please review this rather than #1