[Review Only] Landing livedev2 in core #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for landing livedev2 as an alternative implementation, a folder /impls was created under LiveDevelopment folder and a the current implementation moved to a /default folder. Servers folder and LiveDevServerManager keep in their original location since they will be used as shared resources for both implementations.
Make tests run after moving LiveDevelopment to /impls/default
Copy files from njx/brackets-livedev2. Summary of changes to be integrated into brackets core: - require context, module loading, paths were aligned to the new location - preference names and main.js modified to work on top of current LiveDevelopment UI rather than adding a new launch icon - dependencies for NodeSocketTransportDomain were not included (need to run npm install to get it working) At this point, LiveDevelopment implementation can be manually switched by changing the module that is being load at brackets.js: /impls/default/main.js -> /impls/livedev2/main.js
Add livedev.impl preference to let the user switch between 'default' and 'livedev2' implementations.
Collaborator
There was a problem hiding this comment.
Nit: I know it's not yours, but this should be aligned better.
Collaborator
|
README.md for livedev2 should be part of this PR as well. |
Owner
Author
There was a problem hiding this comment.
yes, it is working now, will remove TODO
Collaborator
|
Why we need a copy of |
It now shows the twipsy that informs the user when the session has finished because of the browser/tab has been closed.
Owner
Author
|
Closing in favor of #4. Feedback from this review was included but we conclude that this approach is not compatible with extensions that depend on LiveDevelopment. |
sebaslv
pushed a commit
that referenced
this pull request
Apr 24, 2015
Review the Getting Started page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@busykai, please review this PR instead of #2. I have excluded dependencies from NodeSocketTrasnportDomain when integrating livedev2 files which makes that commit able to be reviewed now.
This is an initial review to prepare landing of livedev2 in Brackets core as per njx/brackets-livedev2#24