Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix definition of Geo segment #1175

Merged
merged 3 commits into from
Dec 9, 2024
Merged

fix definition of Geo segment #1175

merged 3 commits into from
Dec 9, 2024

Conversation

philblackwood
Copy link
Contributor

closes #1134

@philblackwood philblackwood self-assigned this Dec 3, 2024
@@ -778,6 +778,7 @@ gist:GeoRoute
] ;
skos:definition "An ordered set of GeoPoints that defines a path from starting point to ending point."^^xsd:string ;
skos:prefLabel "Geo Route"^^xsd:string ;
skos:scopeNote "Each pair of consecutive GeoPoints in a GeoRoute is a GeoSegment."^^xsd:string ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to scope note tha A single GeoSegment also a GeoRoute. If it's not now, then probably it should be a subclass.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that GeoSegment is a subclass of GeoRoute with two members, but we are using two different mechanisms to define them. In the case of GeoSegment, we are using comesFrom/goesToPlace, whereas we are using the ordered collection mechanism for GeoRoutes. They don't need to be mutually exclusive, but the way they are currently defined they don't harmonize well. This is considered in issue #1165.

@@ -778,6 +778,7 @@ gist:GeoRoute
] ;
skos:definition "An ordered set of GeoPoints that defines a path from starting point to ending point."^^xsd:string ;
skos:prefLabel "Geo Route"^^xsd:string ;
skos:scopeNote "Each pair of consecutive GeoPoints in a GeoRoute is a GeoSegment."^^xsd:string ;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that GeoSegment is a subclass of GeoRoute with two members, but we are using two different mechanisms to define them. In the case of GeoSegment, we are using comesFrom/goesToPlace, whereas we are using the ordered collection mechanism for GeoRoutes. They don't need to be mutually exclusive, but the way they are currently defined they don't harmonize well. This is considered in issue #1165.

@rjyounes rjyounes merged commit c0a9dc0 into develop Dec 9, 2024
1 check passed
@rjyounes rjyounes deleted the geo-segment branch December 9, 2024 20:50
@MichaelSullivanArchitect

seems to me the definition should possibly change to something like "An ordered set of GeoSegments..."

@uscholdm
Copy link
Contributor

seems to me the definition should possibly change to something like "An ordered set of GeoSegments..."

I think the definition is fine as it is. It may be the case that as a consequence, it is also "An ordered set of GeoSegments...". If so, it could be added as a scope note, if we think it would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix definition of GeoSegment
4 participants