Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix definition of Geo segment #1175

Merged
merged 3 commits into from
Dec 9, 2024
Merged

fix definition of Geo segment #1175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
340fd72
fix definition of GeoSegment #1134
Dec 3, 2024
6c380c9
release note for #1134
Dec 3, 2024
5fa11a0
added scope note stating a geo segment is also a geo route
Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/release_notes/issue1134-geosegment-definition.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix definition of GeoSegment to say it is a portion of the GeoRoute (not a portion of a GeoRegion).
4 changes: 3 additions & 1 deletion ontologies/gistCore.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,6 +778,7 @@ gist:GeoRoute
] ;
skos:definition "An ordered set of GeoPoints that defines a path from starting point to ending point."^^xsd:string ;
skos:prefLabel "Geo Route"^^xsd:string ;
skos:scopeNote "Each pair of consecutive GeoPoints in a GeoRoute is a GeoSegment."^^xsd:string ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to scope note tha A single GeoSegment also a GeoRoute. If it's not now, then probably it should be a subclass.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that GeoSegment is a subclass of GeoRoute with two members, but we are using two different mechanisms to define them. In the case of GeoSegment, we are using comesFrom/goesToPlace, whereas we are using the ordered collection mechanism for GeoRoutes. They don't need to be mutually exclusive, but the way they are currently defined they don't harmonize well. This is considered in issue #1165.

.

gist:GeoSegment
Expand All @@ -800,8 +801,9 @@ gist:GeoSegment
]
) ;
] ;
skos:definition "A single portion of a GeoRegion which has been divided (i.e., segmented)."^^xsd:string ;
skos:definition "A single portion of a GeoRoute consisting of a pair of consecutive GeoPoints which belong to it."^^xsd:string ;
skos:prefLabel "Geo Segment"^^xsd:string ;
skos:scopeNote "A GeoSegment is also a GeoRoute (a short one)."^^xsd:string ;
.

gist:GeoVolume
Expand Down
Loading