-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proper logging library #29
Conversation
Instead of using apache with those unnecessary and bug-prone "features", how about we use |
On second thought (and after seeing its JAR size), I agree that Log4j is indeed overkill for Matcher. I'm not a huge fan of |
Downgrading Matcher from Java 17 to 8, which already has premier support ended, isn't quite a good idea. Lines 36 to 45 in f01ed5a
Your code using matcher directly should migrate to Java 17. 8 is sweet for those sun package stuff and unrestricted reflection to change final fields, but you shouldn't have relied on them in the first place. |
I completely forgot that Matcher uses the Java module system already, so yeah, I should target Java 11 instead. I don't want to force library consumers into requiring Java 17 just yet, especially since Matcher's core functionality doesn't use any Java 12+ features anyway. Player can always bump it later if required. |
e9ca8fa
to
4fb0d13
Compare
88ff6af
to
07a990e
Compare
07a990e
to
d73e8c7
Compare
d73e8c7
to
1556751
Compare
Replaces all
System.out
calls with usages of a proper logger library.Initially I wanted to use SLF4J's API with Log4j as implementation, but I couldn't get it to work with the Java module system, so I just used Log4j's API as well.Now uses SLF4J as API and Tinylog as implementation.Also fixes some inconsistent capitalization of logged sentences.