Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve OSX workflows #2308

Merged
merged 1 commit into from
Dec 5, 2023
Merged

ci: improve OSX workflows #2308

merged 1 commit into from
Dec 5, 2023

Conversation

wellwelwel
Copy link
Collaborator

@wellwelwel wellwelwel commented Dec 5, 2023

👇🏻

@wellwelwel
Copy link
Collaborator Author

wellwelwel commented Dec 5, 2023

This PR improves the OSX workflow time by approximately half.
Now, each OSX matrix takes between 5 and 10 minutes 🧑🏻‍🔧


How it works?

  • ✅ Replacing Lima with Colima will skip an entire download and installation
  • ✅ Installing Docker using --formula from brew instead of the complete Docker installation

Motivation

💸

Screenshot 2023-12-05 at 07 00 55

Also, one of them took more than 13 hours just to fail:

Screenshot 2023-12-05 at 07 14 59

@wellwelwel
Copy link
Collaborator Author

wellwelwel commented Dec 5, 2023

@sidorares, I'm going to merge it to reschedule some OSX that took from 1 hour to more than 6 hours and were never going to finish.


Edit

Unfortunately for Actions sent before this PR, they will continue to run from the previous workflow ☹️

@wellwelwel wellwelwel merged commit 489154f into sidorares:master Dec 5, 2023
57 checks passed
@wellwelwel wellwelwel deleted the osx branch December 5, 2023 19:57
@sidorares
Copy link
Owner

Thanks @wellwelwel ! osx is a low priority and intended to be a smoke test, most production systems are linux based

@wellwelwel wellwelwel mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants