Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs/styling): add dos and donts layout and styling #1780

Open
wants to merge 15 commits into
base: release-3.0.0
Choose a base branch
from

Conversation

matthiashader
Copy link
Collaborator

@matthiashader matthiashader commented Mar 18, 2025

💡 What is the current behavior?

  • Dos / Donts implemented via tsx code

GitHub Issue Number: #N/A, [IX-2420]

🆕 What is the new behavior?

  • dos / donts implemented via adminitions
  • styled dos / donts columns (implement default, do, dont, do-gradient, dont-gradient)

🏁 Checklist

A pull request can only be merged if all of these conditions are met (where applicable):

  • 🦮 Accessibility (a11y) features were implemented
  • 🗺️ Internationalization (i18n) - no hard coded strings
  • 📲 Responsiveness - components handle viewport changes and content overflow gracefully
  • 📄 Documentation was reviewed/updated (pnpm run docs)
  • 🧪 Unit tests were added/updated and pass (pnpm test)
  • 📸 Visual regression tests were added/updated and pass (Guide)
  • 🧐 Static code analysis passes (pnpm lint)
  • 🏗️ Successful compilation (pnpm build, changes pushed)

👨‍💻 Help & support

Copy link

changeset-bot bot commented Mar 18, 2025

⚠️ No Changeset found

Latest commit: 82866e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matthiashader matthiashader marked this pull request as draft March 18, 2025 09:53
Base automatically changed from docs/redesign-v2-release-v3 to release-3.0.0 March 18, 2025 15:47
@matthiashader matthiashader marked this pull request as ready for review March 19, 2025 06:09
Browse …
:::

::::

## Lists
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section also has some do's/dont's

Comment on lines +17 to +18
doGradient: { icon: iconSuccess, iconColor: 'color-success' },
dontGradient: { icon: iconCancelled, iconColor: 'color-alarm' },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these used anywhere or will they be used in the near future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants