Skip to content

feat(docs/styling): add dos and donts layout and styling #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Apr 1, 2025
Merged
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
f175939
feat: add does and donts layout and styling
matthiashader Mar 18, 2025
82fb5b0
feat: adapt docusaurus config
matthiashader Mar 18, 2025
8d4f28a
fix: revert unindented change, format, small fixes
matthiashader Mar 18, 2025
70417ca
fix: sonarqube
matthiashader Mar 18, 2025
b7bce63
Merge branch 'release-3.0.0' into docs/2420-does-donts-layout-styling
matthiashader Mar 19, 2025
bbaf79e
fix: sonarqube issues
matthiashader Mar 19, 2025
a002bc7
fix: sonarqube issues
matthiashader Mar 19, 2025
a58737c
fix: sonarqube issues
matthiashader Mar 19, 2025
7678ebc
Merge remote-tracking branch 'origin/docs/2420-does-donts-layout-stylโ€ฆ
matthiashader Mar 19, 2025
049e31e
fix: moved custom variant to components and changed icon usage
matthiashader Mar 19, 2025
c56d1d6
Merge branch 'release-3.0.0' into docs/2420-does-donts-layout-styling
matthiashader Mar 19, 2025
094a4ae
fix: move css
matthiashader Mar 19, 2025
6a8a8eb
Merge branch 'release-3.0.0' into docs/2420-does-donts-layout-styling
danielleroux Mar 20, 2025
7f25bfa
fix: adjust hierarchy
matthiashader Mar 20, 2025
82866e2
Merge branch 'release-3.0.0' into docs/2420-does-donts-layout-styling
matthiashader Mar 20, 2025
5b6c8c6
fix: resolve do / donts
matthiashader Mar 25, 2025
1e291fd
Merge branch 'release-3.0.0' into docs/2420-does-donts-layout-styling
matthiashader Mar 25, 2025
1ad3124
fix: reimplement admonitions
matthiashader Mar 26, 2025
42aa0f9
Merge branch 'release-3.0.0' into docs/2420-does-donts-layout-styling
matthiashader Mar 26, 2025
225c651
fix: minor issue in md
matthiashader Mar 26, 2025
e7c2068
Merge remote-tracking branch 'origin/docs/2420-does-donts-layout-stylโ€ฆ
matthiashader Mar 26, 2025
ca69a33
fix: minor issue
matthiashader Mar 26, 2025
ce56d94
Merge remote-tracking branch 'origin/docs/2420-does-donts-layout-stylโ€ฆ
matthiashader Mar 26, 2025
0992d0a
fix: removed admonition, reimplemented as react component
matthiashader Mar 26, 2025
70fd158
fix: revert change
matthiashader Mar 26, 2025
63b221c
Merge branch 'release-3.0.0' into docs/2420-does-donts-layout-styling
matthiashader Mar 27, 2025
d4dc02a
docs: fix bullet point formatting
nuke-ellington Mar 28, 2025
70327c6
fix: revert unwanted change
matthiashader Apr 1, 2025
50346b3
Merge remote-tracking branch 'origin/release-3.0.0' into docs/2420-doโ€ฆ
danielleroux Apr 1, 2025
b00b94b
some minor refactoring
danielleroux Apr 1, 2025
19ce587
refactor class usage
danielleroux Apr 1, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
180 changes: 72 additions & 108 deletions packages/documentation/docs/guidelines/language/basics.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,33 +35,27 @@ The following sections contain advice we follow at Siemens to create our own pro

- Avoid using negative contractions as they can appear too informal

<div class="d-flex flex-wrap">
<span class="m-2">
<Guideline do label='their, them, theirs, salesperson'></Guideline>
<Guideline do={false} label='his, hers, him, salesman'></Guideline>
</span>

<span class="m-2">
<Guideline do label='Welcome to this application'></Guideline>
<Guideline do={false} label='Hey there!'></Guideline>
</span>

<span class="m-2">
<Guideline do label='X appears when detail view has selected events'></Guideline>
<Guideline do={false} label='X doesnโ€™t appear if detail view has no selected events'></Guideline>
</span>

<span class="m-2">
<Guideline do label='cannot, will not'></Guideline>
<Guideline do={false} label='canโ€™t, wonโ€™t'></Guideline>
</span>

<span class="m-2">
<Guideline do label='youโ€™ll, weโ€™ve'></Guideline>
<Guideline do={false} label='you will, we have'></Guideline>
</span>

</div>
::::layout

:::col
[!do]
their, them, theirs, salesperson
Welcome to this application
X appears when detail view has selected events
cannot, will not
youโ€™ll, weโ€™ve
:::

:::col
[!dont]
his, hers, him, salesman
Hey there!
X doesnโ€™t appear if detail view has no selected events
canโ€™t, wonโ€™t
you will, we have
:::

::::

### Length

Expand All @@ -85,90 +79,60 @@ The following sections contain advice we follow at Siemens to create our own pro

- Capitalize named app functions and UI elements: Go to Settings, Allocate users in User management, Press Ok

<div class="d-flex flex-wrap">
<span class="m-2">
<Guideline do label='Go to Settings'></Guideline>
<Guideline do={false} label='Go To Settings'></Guideline>
</span>
::::layout

<span class="m-2">
<Guideline do label='Press OK'></Guideline>
<Guideline do={false} label='Press Ok'></Guideline>
</span>
:::col
[!do]
Go to Settings
Press OK
Log in
For more information, see Siemens Industry Online Support.
:::

<span class="m-2">
<Guideline do label='Log in'></Guideline>
<Guideline do={false} label='LOG IN'></Guideline>
</span>
:::col
[!dont]
Go To Settings
Press Ok
LOG IN
For more information, see Siemens industry online support.
:::

<span class="m-2">
<Guideline do label='For more information, see Siemens Industry Online Support.'></Guideline>
<Guideline do={false} label='For more information, see Siemens industry online support.'></Guideline>
</span>

</div>
::::

### Common UX wording mistakes

<div class="d-flex flex-wrap">
<span class="m-2">
<Guideline do label='time zone'></Guideline>
<Guideline do={false} label='timezone'></Guideline>
</span>

<span class="m-2">
<Guideline do label='log file'></Guideline>
<Guideline do={false} label='logfile'></Guideline>
</span>

<span class="m-2">
<Guideline do label='log in (as an action)'></Guideline>
<Guideline do={false} label='login'></Guideline>
</span>

<span class="m-2">
<Guideline do label='login (as a noun)'></Guideline>
<Guideline do={false} label='log in'></Guideline>
</span>

<span class="m-2">
<Guideline do label='equipment'></Guideline>
<Guideline do={false} label='equipments'></Guideline>
</span>

<span class="m-2">
<Guideline do label='feedback'></Guideline>
<Guideline do={false} label='feedbacks'></Guideline>
</span>

<span class="m-2">
<Guideline do label='training'></Guideline>
<Guideline do={false} label='trainings'></Guideline>
</span>

<span class="m-2">
<Guideline do label='current'></Guideline>
<Guideline do={false} label='actual'></Guideline>
</span>

<span class="m-2">
<Guideline do label='avoid "shall"'></Guideline>
<Guideline do={false} label='user shall manage users'></Guideline>
</span>

<span class="m-2">
<Guideline do label='Siemens has'></Guideline>
<Guideline do={false} label='Siemens have'></Guideline>
</span>

<span class="m-2">
<Guideline do label='34 million / 35 billion'></Guideline>
<Guideline do={false} label='34โ€™ / 35โ€œ'></Guideline>
</span>

<span class="m-2">
<Guideline do label='34 million'></Guideline>
<Guideline do={false} label='34 millions'></Guideline>
</span>

</div>
::::layout

:::col
[!do]
time zone
log file
log in (as an action)
login (as a noun)
equipment
feedback
training
current
avoid "shall"
Siemens has
34 million / 35 billion
34 million
:::

:::col
[!dont]
timezone
logfile
login
log in
equipments
feedbacks
trainings
actual
user shall manage users
Siemens have
34โ€™ / 35โ€œ
34 millions
:::

::::
120 changes: 64 additions & 56 deletions packages/documentation/docs/guidelines/language/best-practices.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,28 +15,25 @@ import Guideline from '@site/src/components/Guideline';

- Confirmation messages: Use the same verb as the transitional text

<div class="d-flex flex-wrap">
<span class="m-2">
<Guideline do label='Updating user rolesโ€ฆ'></Guideline>
<Guideline do={false} label='Getting readyโ€ฆ'></Guideline>
</span>

<span class="m-2">
<Guideline do label='Submitting log filesโ€ฆ'></Guideline>
<Guideline do={false} label='Chopping fruitโ€ฆ'></Guideline>
</span>

<span class="m-2">
<Guideline do label='Saving projectโ€ฆ > Project saved'></Guideline>
<Guideline do={false} label='Saving projectโ€ฆ > Project uploaded'></Guideline>
</span>

<span class="m-2">
<Guideline do label='Training modelsโ€ฆ > Models trained'></Guideline>
<Guideline do={false} label='Training modelsโ€ฆ > Training done'></Guideline>
</span>

</div>
::::layout

:::col
[!do]
Updating user rolesโ€ฆ
Submitting log filesโ€ฆ
Saving projectโ€ฆ > Project saved
Training modelsโ€ฆ > Models trained
:::

:::col
[!dont]
Getting readyโ€ฆ
Chopping fruitโ€ฆ
Saving projectโ€ฆ > Project uploaded
Training modelsโ€ฆ > Training done
:::

::::

### Error messages

Expand All @@ -50,15 +47,22 @@ import Guideline from '@site/src/components/Guideline';

- Use โ€ฆ to show an action is required, i.e. fill this in โ€ฆ

<div class="d-flex flex-wrap">
<span class="m-2">
<Guideline do label='System error: Youโ€™re offline. Check your connection and try again.'></Guideline>
<Guideline do label='File error: We cannot upload this file. Try uploading again.'></Guideline>
<Guideline do label='Permission error: To carry out this task, you need more permissions. Contact admin to change permissions. '></Guideline>
<Guideline do={false} label='What did you do!?'></Guideline>
<Guideline do={false} label='The email address you entered does not match the required format. Please enter your email address using the standard format.'></Guideline>
</span>
</div>
::::layout

:::col
[!do]
System error: Youโ€™re offline. Check your connection and try again.
File error: We cannot upload this file. Try uploading again.
Permission error: To carry out this task, you need more permissions. Contact admin to change permissions.
:::

:::col
[!dont]
What did you do!?
The email address you entered does not match the required format. Please enter your email address using the standard format.
:::

::::

### Empty-state text

Expand All @@ -72,23 +76,23 @@ import Guideline from '@site/src/components/Guideline';

- Use wording to show users how to resolve the empty state, e.g. with an action, click, etc.

<div class="d-flex flex-wrap">
<span class="m-2">
<Guideline do label='Allocate users in User management.'></Guideline>
<Guideline do={false} label='No allocated users.'></Guideline>
</span>
::::layout

<span class="m-2">
<Guideline do label='To show rows, select a project.'></Guideline>
<Guideline do={false} label='No rows to show.'></Guideline>
</span>
:::col
[!do]
Allocate users in User management.
To show rows, select a project.
To save a project, select Save in Project detail list.
:::

<span class="m-2">
<Guideline do label='To save a project, select Save in Project detail list.'></Guideline>
<Guideline do={false} label='No projects saved.'></Guideline>
</span>
:::col
[!dont]
No allocated users.
No rows to show.
No projects saved.
:::

</div>
::::

### Restoring behavior of items

Expand All @@ -100,14 +104,18 @@ import Guideline from '@site/src/components/Guideline';

- Do not use Delete and Remove as synonym

<div class="d-flex flex-wrap">
<span class="m-2">
<Guideline do label='Create a chart and delete a chart'></Guideline>
<Guideline do={false} label='Create a chart and remove it'></Guideline>
</span>

<span class="m-2">
<Guideline do label='Add a sensor to a chart and remove a sensor from chart'></Guideline>
<Guideline do={false} label='Add a sensor and delete the sensor'></Guideline>
</span>
</div>
::::layout

:::col
[!do]
Create a chart and delete a chart
Add a sensor to a chart and remove a sensor from chart
:::

:::col
[!dont]
Create a chart and remove it
Add a sensor and delete the sensor
:::

::::
Loading
Loading