Sifive rvv intrinsic xsfvcp #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yulong18
force-pushed
the
sifive-rvv-intrinsic-xsfvcp
branch
from
e242c05 to
865eb47
Compare
|
Hi, @kito-cheng : |
yulong18
force-pushed
the
sifive-rvv-intrinsic-xsfvcp
branch
from
865eb47 to
c944e05
Compare
kito-cheng
reviewed
Dec 12, 2024
There was a problem hiding this comment.
-
I would like to use O[us][0-9][0-9] as a generic immediate operand modifier, so that it can used in other places as well, do you have intestest to post a proposal to riscv-c-api-doc like [RISCV] Inline Assembly: RVC constraint and N modifier llvm/llvm-project#112561
-
could you add vsetvli check in the test case?
-
We don't need X2 here, could you check how wadd.vv and wadd.vx implement? use double_trunc_vector should be work in this case once you adjust the base SEW/LMUL right.
kito-cheng
reviewed
Dec 12, 2024
gcc/config/riscv/sifive-vector.md
Outdated
Comment on lines
186
to
204
| ;; SF_VCP | ||
| (define_insn "@sf_vc_x<mode>" | ||
| [(set (match_operand:VFULLI 0 "register_operand" "=vd") | ||
| (if_then_else:VFULLI | ||
| (unspec:<VM> | ||
| [(match_operand:<VM> 1 "vector_mask_operand" " Wc1") | ||
| (match_operand 7 "vector_length_operand" " rK") | ||
| (match_operand 8 "const_int_operand" " i") | ||
| (match_operand 9 "const_int_operand" " i") | ||
| (match_operand 10 "const_int_operand" " i") | ||
| (reg:SI VL_REGNUM) | ||
| (reg:SI VTYPE_REGNUM)] UNSPEC_VPREDICATE) | ||
| (unspec:VFULLI | ||
| [(match_operand:SI 3 "const_int_operand" "B") | ||
| (match_operand:SI 4 "const_int_operand" "K") | ||
| (match_operand:SI 5 "const_int_operand" "K") | ||
| (match_operand:<VEL> 6 "register_operand" "r")] UNSPEC_SF_CV) | ||
| (match_operand:VFULLI 2 "vector_merge_operand" "vu")))] | ||
| "TARGET_VECTOR && TARGET_XSFVCP" | ||
| "sf.vc.x\t %3, %4, %5, %6" | ||
| [(set_attr "type" "sf_vc_se") | ||
| (set_attr "mode" "<MODE>")]) |
There was a problem hiding this comment.
For those instruction without output, you don't really need a dummy output operand there, you just need some thing like
yulong18
force-pushed
the
sifive-rvv-intrinsic-xsfvcp
branch
2 times, most recently
from
a4b780d to
2c96c6a
Compare
gcc/ChangeLog: * config/riscv/genrvv-type-indexer.cc (expand_floattype): New func. (main): * config/riscv/riscv-vector-builtins-types.def (DEF_RVV_XFQF_OPS): (vint8mf8_t): (vint8mf4_t): (vint8mf2_t): (vint8m1_t): (vint8m2_t): * config/riscv/riscv-vector-builtins.cc (DEF_RVV_XFQF_OPS): (rvv_arg_type_info::get_xfqf_float_type): * config/riscv/riscv-vector-builtins.def (xfqf_vector): (xfqf_float): * config/riscv/riscv-vector-builtins.h (struct rvv_arg_type_info): * config/riscv/sifive-vector.md: * config/riscv/vector-iterators.md:
yulong18
force-pushed
the
sifive-rvv-intrinsic-xsfvcp
branch
from
2c96c6a to
bcc379f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr tries add the intrinsics support for Xsfvcp extension.