PeerDAS implementation #5683

dapplion · 2024-05-01T12:43:28Z

This is an umbrella PR for a PeerDAS implementation.

The plan is to merge smaller PRs from this one into unstable, bit by bit. The PeerDAS feature will be gated behind a config parameter and can coexist with stable code.

Tracking issue ➡️

DAS - Tracking Issue #4983

* Build and publish column sidecars. Add stubs for gossip. * Add blob column subnets * Add `BlobColumnSubnetId` and initial compute subnet logic. * Subscribe to blob column subnets. * Introduce `BLOB_COLUMN_SUBNET_COUNT` based on DAS configuration parameter changes. * Fix column sidecar type to use `VariableList` for data. * Fix lint errors. * Update types and naming to latest consensus-spec #3574. * Fix test and some cleanups.

# Conflicts: # consensus/types/src/chain_spec.rs

* Add stub for `DataColumnsByRoot` * Add basic implementation of serving RPC data column from DA checker. * Store data columns in early attester cache and blobs db. * Apply suggestions from code review Co-authored-by: Eitan Seri-Levi <eserilev@gmail.com> Co-authored-by: Jacob Kaufmann <jacobkaufmann18@gmail.com> * Fix build. * Store `DataColumnInfo` in database and various cleanups. * Update `DataColumnSidecar` ssz max size and remove panic code. --------- Co-authored-by: Eitan Seri-Levi <eserilev@gmail.com> Co-authored-by: Jacob Kaufmann <jacobkaufmann18@gmail.com>

* feat: add DAS KZG in data col construction * refactor data col sidecar construction * refactor: add data cols to GossipVerifiedBlockContents * Disable windows tests for `das` branch. (c-kzg doesn't build on windows) * Formatting and lint changes only. * refactor: remove iters in construction of data cols * Update vec capacity and error handling. * Add `data_column_sidecar_computation_seconds` metric. --------- Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>

# Conflicts: # .github/workflows/test-suite.yml # beacon_node/lighthouse_network/src/types/topics.rs

* feat: add peerdas custody field to ENR * add hash prefix step in subnet computation * refactor test and fix possible u64 overflow * default to min custody value if not present in ENR

# Conflicts: # Cargo.lock # beacon_node/beacon_chain/src/data_availability_checker.rs # beacon_node/beacon_chain/src/data_availability_checker/availability_view.rs # beacon_node/beacon_chain/src/data_availability_checker/overflow_lru_cache.rs # beacon_node/beacon_chain/src/data_availability_checker/processing_cache.rs # beacon_node/lighthouse_network/src/rpc/methods.rs # beacon_node/network/src/network_beacon_processor/mod.rs # beacon_node/network/src/sync/block_lookups/tests.rs # crypto/kzg/Cargo.toml

… block importability (#5570) * Only import custody data columns after publishing a block. * Add `subscribe-all-data-column-subnets` and pass custody column count to `availability_cache`. * Add custody requirement checks to `availability_cache`. * Fix config not being passed to DAChecker and add more logging. * Introduce `peer_das_epoch` and make blobs and columns mutually exclusive. * Add DA filter for PeerDAS. * Fix data availability check and use test_logger in tests. * Fix subscribe to all data column subnets not working correctly. * Fix tests. * Only publish column sidecars if PeerDAS is activated. Add `PEER_DAS_EPOCH` chain spec serialization. * Remove unused data column index in `OverflowKey`. * Fix column sidecars incorrectly produced when there are no blobs. * Re-instate index to `OverflowKey::DataColumn` and downgrade noisy debug log to `trace`.

@jimmygchen

* Data availability sampling on sync * Address @jimmygchen review * Trigger sampling * Address some review comments and only send `SamplingBlock` sync message after PEER_DAS_EPOCH. --------- Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>

# Conflicts: # Cargo.lock # Cargo.toml # beacon_node/beacon_chain/src/block_verification.rs # beacon_node/http_api/src/publish_blocks.rs # beacon_node/lighthouse_network/src/rpc/codec/ssz_snappy.rs # beacon_node/lighthouse_network/src/rpc/protocol.rs # beacon_node/lighthouse_network/src/types/pubsub.rs # beacon_node/network/src/sync/block_lookups/single_block_lookup.rs # beacon_node/store/src/hot_cold_store.rs # consensus/types/src/beacon_state.rs # consensus/types/src/chain_spec.rs # consensus/types/src/eth_spec.rs

* Re-process early sampling requests # Conflicts: # beacon_node/beacon_processor/src/work_reprocessing_queue.rs # beacon_node/lighthouse_network/src/rpc/methods.rs # beacon_node/network/src/network_beacon_processor/rpc_methods.rs * Update beacon_node/beacon_processor/src/work_reprocessing_queue.rs Co-authored-by: Jimmy Chen <jchen.tc@gmail.com> * Add missing var * Beta compiler fixes and small typo fixes. * Remove duplicate method. --------- Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>

* Add data columns by root to currently supported protocol list. * Add missing data column by roots handling.

# Conflicts: # Cargo.lock # Cargo.toml # beacon_node/network/src/sync/block_lookups/tests.rs # beacon_node/network/src/sync/manager.rs

* Bump genesis delay in sim tests as KZG setup takes longer for DAS. * Fix incorrect YAML spacing.

* add boilerplate * fmt

* Implement custody sync * Lint * Fix tests * Fix rebase issue

jimmygchen

Looks good to me! Let's go🚀

jimmygchen · 2024-08-22T07:14:14Z

btw if we're merging this PR with mergify, mergify will delete the das branch and automatically close all PRs targeting das:
https://github.com/sigp/lighthouse/pulls?q=is%3Apr+is%3Aopen+label%3Adas

testing/ef_tests/check_all_files_accessed.py

beacon_node/beacon_chain/src/blob_verification.rs

beacon_node/beacon_processor/src/metrics.rs

realbigsean · 2024-08-22T16:47:02Z

beacon_node/lighthouse_network/src/service/api_types.rs

+#[derive(Debug, Hash, PartialEq, Eq, Clone, Copy)]
+pub struct CustodyId {
+    pub requester: CustodyRequester,
+    pub req_id: Id,


should this be a CustodyRequestId newtype similar to SamplingRequestId?

realbigsean · 2024-08-22T16:49:29Z

beacon_node/lighthouse_network/src/types/globals.rs

+
+    /// Returns a connected peer that:
+    /// 1. is connected
+    /// 2. assigned to custody the column based on it's `custody_subnet_count` from ENR or metadata (WIP)


is this still a WIP?

Metadatav3 completes this wip

realbigsean · 2024-08-22T18:23:14Z

beacon_node/network/src/sync/sampling.rs

+    }
+}
+
+mod request {


separate file?

realbigsean · 2024-08-22T18:24:18Z

Had some relatively inconsequential feed back but looks good overall! 🚀

pawanjay176

Nothing major, gonna go over for a few more files tomorrow

pawanjay176 · 2024-08-22T19:24:42Z

scripts/local_testnet/network_params_das_devnet_1.yaml

Not sure if the devnet config file should go to unstable

agree, @jimmygchen can we delete this?

consensus/types/src/runtime_var_list.rs

beacon_node/src/cli.rs

pawanjay176 · 2024-08-22T22:37:59Z

beacon_node/network/src/sync/range_sync/chain.rs

+    /// Checks all custody column subnets for peers. Returns `true` if there is at least one peer in
+    /// every custody column subnet.
+    fn good_peers_on_custody_subnets(&self, epoch: Epoch, network: &SyncNetworkContext<T>) -> bool {
+        if network.chain.spec.is_peer_das_enabled_for_epoch(epoch) {


Might be good to tweak the function docs to specify we check that peerdas is enabled

beacon_node/beacon_chain/src/metrics.rs

pawanjay176 · 2024-08-23T01:48:58Z

beacon_node/lighthouse_network/src/peer_manager/peerdb.rs

+                        &self.spec,
+                    )
+                    .collect::<HashSet<_>>();
+                    info.set_custody_subnets(custody_subnets);


just noting that we'll have a list of custody subnets for all our peers on mainnet too with this.
Don't see anything harmful with this though other than some extra memory

pawanjay176

LGTM as a whole. My main focus was testing that merging this doesn't affect mainnet nodes adversely.
Will review sampling and custody logic on peerdas devnets.
Tested range sync and lookup sync on mainnet in different scenarios and haven't faced any issues. Great work on pushing this through 🙌
Just one question.

beacon_node/beacon_chain/src/data_availability_checker/overflow_lru_cache.rs

* update subnet count & custody req * das network params * update ef tests --------- Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>

michaelsproul · 2024-08-27T04:07:53Z

@mergify queue

mergify · 2024-08-27T04:08:00Z

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at f75a2cf

dapplion

So happy to see this merged 🎉 big thanks to the reviewers and @jimmygchen

Some post-merge comments

dapplion · 2024-08-26T14:42:28Z

beacon_node/beacon_chain/src/data_availability_checker/overflow_lru_cache.rs

+    /// Potentially trigger reconstruction if:
+    /// - Our custody requirement is all columns
+    /// - We >= 50% of columns, but not all columns


Source code below is self-explanatory enough

Suggested change

/// Potentially trigger reconstruction if:

/// - Our custody requirement is all columns

/// - We >= 50% of columns, but not all columns

/// Returns true if reconstruction should start. Note that reconstruction is started only once.

/// Currently only supernodes expecting all columns will attempt reconstruction.

dapplion · 2024-08-26T14:43:19Z

beacon_node/beacon_chain/src/data_availability_checker/overflow_lru_cache.rs

+        // Potentially trigger reconstruction if:
+        // - Our custody requirement is all columns
+        // - We >= 50% of columns


Suggested change

// Potentially trigger reconstruction if:

// - Our custody requirement is all columns

// - We >= 50% of columns

dapplion · 2024-08-26T14:46:09Z

beacon_node/beacon_chain/src/metrics.rs

+    LazyLock::new(|| {
+        try_create_histogram(
+            "data_column_sidecar_inclusion_proof_verification_seconds",
+            "Time taken to verify data_column sidecar inclusion proof",


Should add proper bucket values to the new histograms

dapplion · 2024-08-26T14:49:44Z

beacon_node/beacon_processor/src/work_reprocessing_queue.rs

+pub struct QueuedSamplingRequest {
+    pub beacon_block_root: Hash256,
+    pub process_fn: BlockingFn,
+}


Need more metrics around this mechanism to compute

ratio of dropped requests

time of arrival into the slot

time to fulfill into the slot

beacon_node/src/cli.rs

dapplion · 2024-08-27T07:25:46Z

beacon_node/lighthouse_network/src/types/globals.rs

+
+    /// Returns a connected peer that:
+    /// 1. is connected
+    /// 2. assigned to custody the column based on it's `custody_subnet_count` from ENR or metadata (WIP)


Metadatav3 completes this wip

@jimmygchen

* 1D PeerDAS prototype: Data format and Distribution (sigp#5050) * Build and publish column sidecars. Add stubs for gossip. * Add blob column subnets * Add `BlobColumnSubnetId` and initial compute subnet logic. * Subscribe to blob column subnets. * Introduce `BLOB_COLUMN_SUBNET_COUNT` based on DAS configuration parameter changes. * Fix column sidecar type to use `VariableList` for data. * Fix lint errors. * Update types and naming to latest consensus-spec sigp#3574. * Fix test and some cleanups. * Merge branch 'unstable' into das * Merge branch 'unstable' into das * Merge branch 'unstable' into das # Conflicts: # consensus/types/src/chain_spec.rs * Add `DataColumnSidecarsByRoot ` req/resp protocol (sigp#5196) * Add stub for `DataColumnsByRoot` * Add basic implementation of serving RPC data column from DA checker. * Store data columns in early attester cache and blobs db. * Apply suggestions from code review Co-authored-by: Eitan Seri-Levi <eserilev@gmail.com> Co-authored-by: Jacob Kaufmann <jacobkaufmann18@gmail.com> * Fix build. * Store `DataColumnInfo` in database and various cleanups. * Update `DataColumnSidecar` ssz max size and remove panic code. --------- Co-authored-by: Eitan Seri-Levi <eserilev@gmail.com> Co-authored-by: Jacob Kaufmann <jacobkaufmann18@gmail.com> * feat: add DAS KZG in data col construction (sigp#5210) * feat: add DAS KZG in data col construction * refactor data col sidecar construction * refactor: add data cols to GossipVerifiedBlockContents * Disable windows tests for `das` branch. (c-kzg doesn't build on windows) * Formatting and lint changes only. * refactor: remove iters in construction of data cols * Update vec capacity and error handling. * Add `data_column_sidecar_computation_seconds` metric. --------- Co-authored-by: Jimmy Chen <jchen.tc@gmail.com> * Merge branch 'unstable' into das # Conflicts: # .github/workflows/test-suite.yml # beacon_node/lighthouse_network/src/types/topics.rs * fix: update data col subnet count from 64 to 32 (sigp#5413) * feat: add peerdas custody field to ENR (sigp#5409) * feat: add peerdas custody field to ENR * add hash prefix step in subnet computation * refactor test and fix possible u64 overflow * default to min custody value if not present in ENR * Merge branch 'unstable' into das * Merge branch 'unstable' into das-unstable-merge-0415 # Conflicts: # Cargo.lock # beacon_node/beacon_chain/src/data_availability_checker.rs # beacon_node/beacon_chain/src/data_availability_checker/availability_view.rs # beacon_node/beacon_chain/src/data_availability_checker/overflow_lru_cache.rs # beacon_node/beacon_chain/src/data_availability_checker/processing_cache.rs # beacon_node/lighthouse_network/src/rpc/methods.rs # beacon_node/network/src/network_beacon_processor/mod.rs # beacon_node/network/src/sync/block_lookups/tests.rs # crypto/kzg/Cargo.toml * Merge remote-tracking branch 'sigp/unstable' into das * Merge remote-tracking branch 'sigp/unstable' into das * Fix merge conflicts. * Send custody data column to `DataAvailabilityChecker` for determining block importability (sigp#5570) * Only import custody data columns after publishing a block. * Add `subscribe-all-data-column-subnets` and pass custody column count to `availability_cache`. * Add custody requirement checks to `availability_cache`. * Fix config not being passed to DAChecker and add more logging. * Introduce `peer_das_epoch` and make blobs and columns mutually exclusive. * Add DA filter for PeerDAS. * Fix data availability check and use test_logger in tests. * Fix subscribe to all data column subnets not working correctly. * Fix tests. * Only publish column sidecars if PeerDAS is activated. Add `PEER_DAS_EPOCH` chain spec serialization. * Remove unused data column index in `OverflowKey`. * Fix column sidecars incorrectly produced when there are no blobs. * Re-instate index to `OverflowKey::DataColumn` and downgrade noisy debug log to `trace`. * DAS sampling on sync (sigp#5616) * Data availability sampling on sync * Address @jimmygchen review * Trigger sampling * Address some review comments and only send `SamplingBlock` sync message after PEER_DAS_EPOCH. --------- Co-authored-by: Jimmy Chen <jchen.tc@gmail.com> * Merge branch 'unstable' into das # Conflicts: # Cargo.lock # Cargo.toml # beacon_node/beacon_chain/src/block_verification.rs # beacon_node/http_api/src/publish_blocks.rs # beacon_node/lighthouse_network/src/rpc/codec/ssz_snappy.rs # beacon_node/lighthouse_network/src/rpc/protocol.rs # beacon_node/lighthouse_network/src/types/pubsub.rs # beacon_node/network/src/sync/block_lookups/single_block_lookup.rs # beacon_node/store/src/hot_cold_store.rs # consensus/types/src/beacon_state.rs # consensus/types/src/chain_spec.rs # consensus/types/src/eth_spec.rs * Merge branch 'unstable' into das * Re-process early sampling requests (sigp#5569) * Re-process early sampling requests # Conflicts: # beacon_node/beacon_processor/src/work_reprocessing_queue.rs # beacon_node/lighthouse_network/src/rpc/methods.rs # beacon_node/network/src/network_beacon_processor/rpc_methods.rs * Update beacon_node/beacon_processor/src/work_reprocessing_queue.rs Co-authored-by: Jimmy Chen <jchen.tc@gmail.com> * Add missing var * Beta compiler fixes and small typo fixes. * Remove duplicate method. --------- Co-authored-by: Jimmy Chen <jchen.tc@gmail.com> * Merge remote-tracking branch 'sigp/unstable' into das * Fix merge conflict. * Add data columns by root to currently supported protocol list (sigp#5678) * Add data columns by root to currently supported protocol list. * Add missing data column by roots handling. * Merge branch 'unstable' into das # Conflicts: # Cargo.lock # Cargo.toml # beacon_node/network/src/sync/block_lookups/tests.rs # beacon_node/network/src/sync/manager.rs * Fix simulator tests on `das` branch (sigp#5731) * Bump genesis delay in sim tests as KZG setup takes longer for DAS. * Fix incorrect YAML spacing. * DataColumnByRange boilerplate (sigp#5353) * add boilerplate * fmt * PeerDAS custody lookup sync (sigp#5684) * Implement custody sync * Lint * Fix tests * Fix rebase issue * Add data column kzg verification and update `c-kzg`. (sigp#5701) * Add data column kzg verification and update `c-kzg`. * Fix incorrect `Cell` size. * Add kzg verification on rpc blocks. * Add kzg verification on rpc data columns. * Rename `PEER_DAS_EPOCH` to `EIP7594_FORK_EPOCH` for client interop. (sigp#5750) * Fetch custody columns in range sync (sigp#5747) * Fetch custody columns in range sync * Clean up todos * Remove `BlobSidecar` construction and publish after PeerDAS activated (sigp#5759) * Avoid building and publishing blob sidecars after PeerDAS. * Ignore gossip blobs with a slot greater than peer das activation epoch. * Only attempt to verify blob count and import blobs before PeerDAS. * sigp#5684 review comments (sigp#5748) * sigp#5684 review comments. * Doc and message update only. * Fix incorrect condition when constructing `RpcBlock` with `DataColumn`s * Make sampling tests deterministic (sigp#5775) * PeerDAS spec tests (sigp#5772) * Add get_custody_columns spec tests. * Add kzg merkle proof spec tests. * Add SSZ spec tests. * Add remaining KZG tests * Load KZG only once per process, exclude electra tests and add missing SSZ tests. * Fix lint and missing changes. * Ignore macOS generated file. * Merge remote branch 'sigp/unstable' into das * Merge remote tracking branch 'origin/unstable' into das * Implement unconditional reconstruction for supernodes (sigp#5781) * Implement unconditional reconstruction for supernodes * Move code into KzgVerifiedCustodyDataColumn * Remove expect * Add test * Thanks justin * Add withhold attack mode for interop (sigp#5788) * Add withhold attack mode * Update readme * Drop added readmes * Undo styling changes * Add column gossip verification and handle unknown parent block (sigp#5783) * Add column gossip verification and handle missing parent for columns. * Review PR * Fix rebase issue * more lint issues :) --------- Co-authored-by: dapplion <35266934+dapplion@users.noreply.github.com> * Trigger sampling on sync events (sigp#5776) * Trigger sampling on sync events * Update beacon_chain.rs * Fix tests * Fix tests * PeerDAS parameter changes for devnet-0 (sigp#5779) * Update PeerDAS parameters to latest values. * Lint fix * Fix lint. * Update hardcoded subnet count to 64 (sigp#5791) * Fix incorrect columns per subnet and config cleanup (sigp#5792) * Tidy up PeerDAS preset and config values. * Fix broken config * Fix DAS branch CI (sigp#5793) * Fix invalid syntax. * Update cli doc. Ignore get_custody_columns test temporarily. * Fix failing test and add verify inclusion test. * Undo accidentally removed code. * Only attempt reconstruct columns once. (sigp#5794) * Re-enable precompute table for peerdas kzg (sigp#5795) * Merge branch 'unstable' into das * Update subscription filter. (sigp#5797) * Remove penalty for duplicate columns (expected due to reconstruction) (sigp#5798) * Revert DAS config for interop testing. Optimise get_custody_columns function. (sigp#5799) * Don't perform reconstruction for proposer node as it already has all the columns. (sigp#5806) * Multithread compute_cells_and_proofs (sigp#5805) * Multi-thread reconstruct data columns * Multi-thread path for block production * Merge branch 'unstable' into das # Conflicts: # .github/workflows/test-suite.yml # beacon_node/network/src/sync/block_lookups/mod.rs # beacon_node/network/src/sync/block_lookups/single_block_lookup.rs # beacon_node/network/src/sync/network_context.rs * Fix CI errors. * Move PeerDAS type-level config to configurable `ChainSpec` (sigp#5828) * Move PeerDAS type level config to `ChainSpec`. * Fix tests * Misc custody lookup improvements (sigp#5821) * Improve custody requests * Type DataColumnsByRootRequestId * Prioritize peers and load balance * Update tests * Address PR review * Merge branch 'unstable' into das * Rename deploy_block in network config (`das` branch) (sigp#5852) * Rename deploy_block.txt to deposit_contract_block.txt * fmt --------- Co-authored-by: Pawan Dhananjay <pawandhananjay@gmail.com> * Merge branch 'unstable' into das * Fix CI and merge issues. * Merge branch 'unstable' into das # Conflicts: # beacon_node/beacon_chain/src/data_availability_checker/overflow_lru_cache.rs # lcli/src/main.rs * Store data columns individually in store and caches (sigp#5890) * Store data columns individually in store and caches * Implement data column pruning * Merge branch 'unstable' into das # Conflicts: # Cargo.lock * Update reconstruction benches to newer criterion version. (sigp#5949) * Merge branch 'unstable' into das # Conflicts: # .github/workflows/test-suite.yml * chore: add `recover_cells_and_compute_proofs` method (sigp#5938) * chore: add recover_cells_and_compute_proofs method * Introduce type alias `CellsAndKzgProofs` to address type complexity. --------- Co-authored-by: Jimmy Chen <jchen.tc@gmail.com> * Update `csc` format in ENR and spec tests for devnet-1 (sigp#5966) * Update `csc` format in ENR. * Add spec tests for `recover_cells_and_kzg_proofs`. * Add tests for ENR. * Fix failing tests. * Add protection against invalid csc value in ENR. * Fix lint * Fix csc encoding and decoding (sigp#5997) * Fix data column rpc request not being sent due to incorrect limits set. (sigp#6000) * Fix incorrect inbound request count causing rate limiting. (sigp#6025) * Merge branch 'stable' into das # Conflicts: # beacon_node/network/src/sync/block_lookups/tests.rs # beacon_node/network/src/sync/block_sidecar_coupling.rs # beacon_node/network/src/sync/manager.rs # beacon_node/network/src/sync/network_context.rs # beacon_node/network/src/sync/network_context/requests.rs * Merge remote-tracking branch 'unstable' into das * Add kurtosis config for DAS testing (sigp#5968) * Add kurtosis config for DAS testing. * Fix invalid yaml file * Update network parameter files. * chore: add rust PeerdasKZG crypto library for peerdas functionality and rollback c-kzg dependency to 4844 version (sigp#5941) * chore: add recover_cells_and_compute_proofs method * chore: add rust peerdas crypto library * chore: integrate peerdaskzg rust library into kzg crate * chore(multi): - update `ssz_cell_to_crypto_cell` - update conversion from the crypto cell type to a Vec<u8>. Since the Rust library defines them as references to an array, the conversion is simply `to_vec` * chore(multi): - update rest of code to handle the new crypto `Cell` type - update test case code to no longer use the Box type * chore: cleanup of superfluous conversions * chore: revert c-kzg dependency back to v1 * chore: move dependency into correct order * chore: update rust dependency - This version includes a new method `PeerDasContext::with_num_threads` * chore: remove Default initialization of PeerDasContext and explicitly set the parameters in `new_from_trusted_setup` * chore: cleanup exports * chore: commit updated cargo.lock * Update Cargo.toml Co-authored-by: Jimmy Chen <jchen.tc@gmail.com> * chore: rename dependency * chore: update peerdas lib - sets the blst version to 0.3 so that it matches whatever lighthouse is using. Although 0.3.12 is latest, lighthouse is pinned to 0.3.3 * chore: fix clippy lifetime - Rust doesn't allow you to elide the lifetime on type aliases * chore: cargo clippy fix * chore: cargo fmt * chore: update lib to add redundant checks (these will be removed in consensus-specs PR 3819) * chore: update dependency to ignore proofs * chore: update peerdas lib to latest * update lib * chore: remove empty proof parameter --------- Co-authored-by: Jimmy Chen <jchen.tc@gmail.com> * Update PeerDAS interop testnet config (sigp#6069) * Update interop testnet config. * Fix typo and remove target peers * Avoid retrying same sampling peer that previously failed. (sigp#6084) * Various fixes to custody range sync (sigp#6004) * Only start requesting batches when there are good peers across all custody columns to avoid spaming block requests. * Add custody peer check before mutating `BatchInfo` to avoid inconsistent state. * Add check to cover a case where batch is not processed while waiting for custody peers to become available. * Fix lint and logic error * Fix `good_peers_on_subnet` always returning false for `DataColumnSubnet`. * Add test for `get_custody_peers_for_column` * Revert epoch parameter refactor. * Fall back to default custody requiremnt if peer ENR is not present. * Add metrics and update code comment. * Add more debug logs. * Use subscribed peers on subnet before MetaDataV3 is implemented. Remove peer_id matching when injecting error because multiple peers are used for range requests. Use randomized custodial peer to avoid repeatedly sending requests to failing peers. Batch by range request where possible. * Remove unused code and update docs. * Add comment * chore: update peerdas-kzg library (sigp#6118) * chore: update peerDAS lib * chore: update library * chore: update library to version that include "init context" benchmarks and optional validation checks * chore: (can remove) -- Add benchmarks for init context * Prevent continuous searchers for low-peer networks (sigp#6162) * Merge branch 'unstable' into das * Fix merge conflicts * Add cli flag to enable sampling and disable by default. (sigp#6209) * chore: Use reference to an array representing a blob instead of an owned KzgBlob (sigp#6179) * add KzgBlobRef type * modify code to use KzgBlobRef * clippy * Remove Deneb blob related changes to maintain compatibility with `c-kzg-4844`. --------- Co-authored-by: Jimmy Chen <jchen.tc@gmail.com> * Store computed custody subnets in PeerDB and fix custody lookup test (sigp#6218) * Fix failing custody lookup tests. * Store custody subnets in PeerDB, fix custody lookup test and refactor some methods. * Merge branch 'unstable' into das # Conflicts: # beacon_node/beacon_chain/src/beacon_chain.rs # beacon_node/beacon_chain/src/block_verification_types.rs # beacon_node/beacon_chain/src/builder.rs # beacon_node/beacon_chain/src/data_availability_checker.rs # beacon_node/beacon_chain/src/data_availability_checker/overflow_lru_cache.rs # beacon_node/beacon_chain/src/data_column_verification.rs # beacon_node/beacon_chain/src/early_attester_cache.rs # beacon_node/beacon_chain/src/historical_blocks.rs # beacon_node/beacon_chain/tests/store_tests.rs # beacon_node/lighthouse_network/src/discovery/enr.rs # beacon_node/network/src/service.rs # beacon_node/src/cli.rs # beacon_node/store/src/hot_cold_store.rs # beacon_node/store/src/lib.rs # lcli/src/generate_bootnode_enr.rs * Fix CI failures after merge. * Batch sampling requests by peer (sigp#6256) * Batch sampling requests by peer * Fix clippy errors * Fix tests * Add column_index to error message for ease of tracing * Remove outdated comment * Fix range sync never evaluating request as finished, causing it to get stuck. (sigp#6276) * Merge branch 'unstable' into das-0821-merge # Conflicts: # Cargo.lock # Cargo.toml # beacon_node/beacon_chain/src/beacon_chain.rs # beacon_node/beacon_chain/src/data_availability_checker.rs # beacon_node/beacon_chain/src/data_availability_checker/overflow_lru_cache.rs # beacon_node/beacon_chain/src/data_column_verification.rs # beacon_node/beacon_chain/src/kzg_utils.rs # beacon_node/beacon_chain/src/metrics.rs # beacon_node/beacon_processor/src/lib.rs # beacon_node/lighthouse_network/src/rpc/codec/ssz_snappy.rs # beacon_node/lighthouse_network/src/rpc/config.rs # beacon_node/lighthouse_network/src/rpc/methods.rs # beacon_node/lighthouse_network/src/rpc/outbound.rs # beacon_node/lighthouse_network/src/rpc/rate_limiter.rs # beacon_node/lighthouse_network/src/service/api_types.rs # beacon_node/lighthouse_network/src/types/globals.rs # beacon_node/network/src/network_beacon_processor/mod.rs # beacon_node/network/src/network_beacon_processor/rpc_methods.rs # beacon_node/network/src/network_beacon_processor/sync_methods.rs # beacon_node/network/src/sync/block_lookups/common.rs # beacon_node/network/src/sync/block_lookups/mod.rs # beacon_node/network/src/sync/block_lookups/single_block_lookup.rs # beacon_node/network/src/sync/block_lookups/tests.rs # beacon_node/network/src/sync/manager.rs # beacon_node/network/src/sync/network_context.rs # consensus/types/src/data_column_sidecar.rs # crypto/kzg/Cargo.toml # crypto/kzg/benches/benchmark.rs # crypto/kzg/src/lib.rs * Fix custody tests and load PeerDAS KZG instead. * Fix ef tests and bench compilation. * Fix failing sampling test. * Merge pull request sigp#6287 from jimmygchen/das-0821-merge Merge `unstable` into `das` 20240821 * Remove get_block_import_status * Merge branch 'unstable' into das * Re-enable Windows release tests. * Address some review comments. * Address more review comments and cleanups. * Comment out peer DAS KZG EF tests for now * Address more review comments and fix build. * Merge branch 'das' of github.com:sigp/lighthouse into das * Unignore Electra tests * Fix metric name * Address some of Pawan's review comments * Merge remote-tracking branch 'origin/unstable' into das * Update PeerDAS network parameters for peerdas-devnet-2 (sigp#6290) * update subnet count & custody req * das network params * update ef tests --------- Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>

jimmygchen and others added 20 commits February 5, 2024 19:53

Merge branch 'unstable' into das

79fa78f

Merge branch 'unstable' into das

e740e78

Merge branch 'unstable' into das

28756da

# Conflicts: # consensus/types/src/chain_spec.rs

Merge branch 'unstable' into das

14a85fe

# Conflicts: # .github/workflows/test-suite.yml # beacon_node/lighthouse_network/src/types/topics.rs

fix: update data col subnet count from 64 to 32 (#5413)

1317f70

feat: add peerdas custody field to ENR (#5409)

7108c74

* feat: add peerdas custody field to ENR * add hash prefix step in subnet computation * refactor test and fix possible u64 overflow * default to min custody value if not present in ENR

Merge branch 'unstable' into das

d5e7e73

Merge remote-tracking branch 'sigp/unstable' into das

5750d49

Merge remote-tracking branch 'sigp/unstable' into das

254bb6e

Fix merge conflicts.

d71dc58

DAS sampling on sync (#5616)

75eab79

* Data availability sampling on sync * Address @jimmygchen review * Trigger sampling * Address some review comments and only send `SamplingBlock` sync message after PEER_DAS_EPOCH. --------- Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>

Merge branch 'unstable' into das

cb11a16

Merge remote-tracking branch 'sigp/unstable' into das

2c82fad

dapplion added work-in-progress PR is a work-in-progress Networking electra Required for the Electra/Prague fork labels May 1, 2024

dapplion changed the title ~~Das~~ PeerDAS implementation May 1, 2024

jimmygchen and others added 6 commits May 2, 2024 15:07

Fix merge conflict.

d5f3562

Add data columns by root to currently supported protocol list (#5678)

0644709

* Add data columns by root to currently supported protocol list. * Add missing data column by roots handling.

Merge branch 'unstable' into das

a857546

# Conflicts: # Cargo.lock # Cargo.toml # beacon_node/network/src/sync/block_lookups/tests.rs # beacon_node/network/src/sync/manager.rs

Fix simulator tests on das branch (#5731)

bc190e7

* Bump genesis delay in sim tests as KZG setup takes longer for DAS. * Fix incorrect YAML spacing.

DataColumnByRange boilerplate (#5353)

bc51e70

* add boilerplate * fmt

PeerDAS custody lookup sync (#5684)

a970f64

* Implement custody sync * Lint * Fix tests * Fix rebase issue

Address more review comments and cleanups.

93329c0

jimmygchen approved these changes Aug 22, 2024

View reviewed changes

Comment out peer DAS KZG EF tests for now

e049294

michaelsproul mentioned this pull request Aug 22, 2024

Deterministic RNG in peer DAS publish block tests #6296

Open

jimmygchen added 2 commits August 22, 2024 16:49

Address more review comments and fix build.

c44bc0a

Merge branch 'das' of github.com:sigp/lighthouse into das

3c4b7f9

jimmygchen added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Aug 22, 2024

jimmygchen requested review from realbigsean and pawanjay176 August 22, 2024 07:07

realbigsean approved these changes Aug 22, 2024

View reviewed changes

michaelsproul added 2 commits August 23, 2024 10:41

Unignore Electra tests

45b3203

Fix metric name

63a39b7

pawanjay176 requested changes Aug 23, 2024

View reviewed changes

Address some of Pawan's review comments

77caa97

michaelsproul mentioned this pull request Aug 26, 2024

Implement Electra spec v1.5.0-alpha.5 #6305

Merged

pawanjay176 approved these changes Aug 26, 2024

View reviewed changes

beacon_node/beacon_chain/src/data_availability_checker/overflow_lru_cache.rs Show resolved Hide resolved

michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Aug 26, 2024

michaelsproul and others added 2 commits August 27, 2024 10:12

Merge remote-tracking branch 'origin/unstable' into das

7db3e1c

Update PeerDAS network parameters for peerdas-devnet-2 (#6290)

2c16052

* update subnet count & custody req * das network params * update ef tests --------- Co-authored-by: Jimmy Chen <jchen.tc@gmail.com>

mergify bot merged commit f75a2cf into unstable Aug 27, 2024
28 checks passed

mergify bot deleted the das branch August 27, 2024 04:10

michaelsproul restored the das branch August 27, 2024 04:20

dapplion commented Aug 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PeerDAS implementation #5683

PeerDAS implementation #5683

dapplion commented May 1, 2024

jimmygchen left a comment

jimmygchen commented Aug 22, 2024

realbigsean Aug 22, 2024

realbigsean Aug 22, 2024

dapplion Aug 27, 2024

realbigsean Aug 22, 2024

realbigsean commented Aug 22, 2024

pawanjay176 left a comment

pawanjay176 Aug 22, 2024

michaelsproul Aug 23, 2024

pawanjay176 Aug 22, 2024

pawanjay176 Aug 23, 2024

pawanjay176 left a comment

michaelsproul commented Aug 27, 2024

mergify bot commented Aug 27, 2024 •

edited

Loading

dapplion left a comment

dapplion Aug 26, 2024

dapplion Aug 26, 2024

dapplion Aug 26, 2024

dapplion Aug 26, 2024

dapplion Aug 27, 2024

	// Potentially trigger reconstruction if:
	// - Our custody requirement is all columns
	// - We >= 50% of columns

PeerDAS implementation #5683

PeerDAS implementation #5683

Conversation

dapplion commented May 1, 2024

jimmygchen left a comment

Choose a reason for hiding this comment

jimmygchen commented Aug 22, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

realbigsean commented Aug 22, 2024

pawanjay176 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pawanjay176 left a comment

Choose a reason for hiding this comment

michaelsproul commented Aug 27, 2024

mergify bot commented Aug 27, 2024 • edited Loading

✅ The pull request has been merged automatically

dapplion left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mergify bot commented Aug 27, 2024 •

edited

Loading