Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Light Client server by default #6950

Merged
merged 4 commits into from
Feb 10, 2025

Conversation

eserilev
Copy link
Collaborator

@eserilev eserilev commented Feb 7, 2025

Deprecate the light-client-server flag, enable light client server by default and introduce a new flag disable-light-client-server

@eserilev eserilev requested a review from jxs as a code owner February 7, 2025 12:08
@michaelsproul michaelsproul added the v7.0.0-beta.0 New release c. Q1 2025 label Feb 7, 2025
@eserilev
Copy link
Collaborator Author

eserilev commented Feb 9, 2025

Light client dashboard metrics

Roughly 1 light client data processing request per slot

image

Light client data computation time: 25ms

image

State merkle proof computation times on the order of milliseconds

image

No block cache misses in the last 30 days

image

No light client data computation failures in the last 30 days

image

Negligible relative increase in db store disk size over last 30 days

image

No visible increase in CPU/memory usage over the last 30 days

image image

No visibile increase in read/write IO operations/Throughput

image image

Note that on local testing I also saw negligible increases in cpu usage, IO, memory usage and disk space when running the light client vs not running the light client server

Copy link
Member

@michaelsproul michaelsproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

I've just added a WARN log so that users know to remove the old --light-client-server flag.

@michaelsproul michaelsproul added the ready-for-merge This PR is ready to merge. label Feb 10, 2025
mergify bot added a commit that referenced this pull request Feb 10, 2025
michaelsproul added a commit that referenced this pull request Feb 10, 2025
Squashed commit of the following:

commit e4ede45
Author: Michael Sproul <michael@sigmaprime.io>
Date:   Mon Feb 10 11:16:40 2025 +1100

    Add deprecation warning log

commit 022f3f8
Author: Eitan Seri-Levi <eserilev@ucsc.edu>
Date:   Fri Feb 7 14:58:03 2025 +0200

    fix test

commit 325e71c
Author: Eitan Seri-Levi <eserilev@ucsc.edu>
Date:   Fri Feb 7 14:07:11 2025 +0200

    add cli changes

commit 74d93f6
Author: Eitan Seri-Levi <eserilev@ucsc.edu>
Date:   Fri Feb 7 13:36:37 2025 +0200

    Enable Light Client server by default
@michaelsproul michaelsproul mentioned this pull request Feb 10, 2025
7 tasks
@mergify mergify bot merged commit afdda83 into sigp:unstable Feb 10, 2025
32 checks passed
mergify bot pushed a commit that referenced this pull request Feb 13, 2025
New release for Electra on Holesky and Sepolia.

Includes PRs:

- #6808
- #6914
- #6949
- #6950
- #6958
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
light-client ready-for-merge This PR is ready to merge. v7.0.0-beta.0 New release c. Q1 2025
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants