-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Light Client server by default #6950
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsproul
approved these changes
Feb 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
I've just added a WARN log so that users know to remove the old --light-client-server
flag.
14 tasks
michaelsproul
added a commit
that referenced
this pull request
Feb 10, 2025
Squashed commit of the following: commit e4ede45 Author: Michael Sproul <michael@sigmaprime.io> Date: Mon Feb 10 11:16:40 2025 +1100 Add deprecation warning log commit 022f3f8 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Fri Feb 7 14:58:03 2025 +0200 fix test commit 325e71c Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Fri Feb 7 14:07:11 2025 +0200 add cli changes commit 74d93f6 Author: Eitan Seri-Levi <eserilev@ucsc.edu> Date: Fri Feb 7 13:36:37 2025 +0200 Enable Light Client server by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the
light-client-server
flag, enable light client server by default and introduce a new flagdisable-light-client-server